428648 - Fix Tag, Day, Host containers attributes

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

We need to fix tag containers icons, since they have the query icon.

2 options here:

1. fix all tag related queries, so Tag icon will appear not only on Tag containers but also on Recent Tags query and in the Library Tags

2. fix tag containers, fix Library, leave Smart Bookmark Recent Tags with generic query icon

I'd vote for the former to make Recent Tags more discoverable in the Bookmarks menu

Comment 1

[Marco Bonardo [:mak]]

marking as regression since is mostly due to 419731 (tag containers are now queries)

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch

included:
- fix tag containers (and tag query) icons
- add a dayContainer attribute (bug 428646)
- fix queries icons on toolbar

Comment 3

[Marco Bonardo [:mak]]

Attachment: screenshot with changes

Comment 4

[Marco Bonardo [:mak]]

query icon in toolbar has been fixed in bug 428098, need to unbitrot

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch

- added hostContainer attribute
- added dayContainer attribute
- fixed attributes set up

The only visible change actually should be tag containers icon.
i've used the folder icon as a placeholder for current missing container icons (there are other bugs that will fix those). hostContainer has the open attribute placeholder because will probably retain folder icon in final version.

Tested on XP and Ubuntu, i'm trying to set up a mac machine to test on, but still need some love.

Notice that tag containers icons will not be replaced in Library for old profiles (left pane queries still need to be updated)

Comment 6

[Asaf Romano (gone)]

Comment on attachment 315650 [details] [diff] [review]
patch

r=mano. Note I asked marco to add the no-op open-rules as a place holder for a regression fix...

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm not sure why we're saying that the Most Recent Tags query should have the same icon as the tags themselves. That icon means "Smart Bookmark Folder" and I don't think we want to dilute that.

Is it simply to make the "All Tags" folder have that icon? What am I missing?

Comment 8

[Marco Bonardo [:mak]]

Comment on attachment 315650 [details] [diff] [review]
patch

Mike that change has been remove in the latest patch (that's why i've removed the UI-revuew request). the patch apply tag icon only to tag containers, not to the smart bookmark. And that's the only visible change (that really is a regression).
Plus we add needed attributes that will allow to decorate day and host containers in the hitory sidebar

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 315650 [details] [diff] [review]
patch

a=beltzner, kthx

Comment 10

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.xml
new revision: 1.152; previous revision: 1.151
done
Checking in browser/components/places/content/treeView.js;
/cvsroot/mozilla/browser/components/places/content/treeView.js,v  <--  treeView.js
new revision: 1.64; previous revision: 1.63
done
Checking in browser/components/places/content/utils.js;
/cvsroot/mozilla/browser/components/places/content/utils.js,v  <--  utils.js
new revision: 1.135; previous revision: 1.134
done
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.209; previous revision: 1.208
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.32; previous revision: 1.31
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.145; previous revision: 1.144
done
Checking in browser/themes/pinstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/places/places.css,v  <--  places.css
new revision: 1.23; previous revision: 1.22
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v  <--  browser.css
new revision: 1.200; previous revision: 1.199
done
Checking in browser/themes/winstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/places.css,v  <--  places.css
new revision: 1.24; previous revision: 1.23
done

Comment 11

[Tracy Walker [:tracy]]

verified with: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041606 Minefield/3.0pre
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008041604 Minefield/3.0pre

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv