428657 - stop using deprecated winable.h, use winuser.h instead

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

We now require the Windows Vista SDK, which no longer includes winable.h. According to MSDN (see URL) this library has been duplicated in winuser.h since January 2005. We should be using this library, instead.

This impacts people who are building on Windows, as after downloading the required SDKs, they need to source and manually add winable.h to get a working build with accessibility.

Comment 1

[Benjamin Smedberg]

"January 2005" is which SDK release? The three SDKs in question are

* win2k3 SDK
* vista SDK (version 6.0)
* win2k8 SDK (version 6.1)

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

The MSDN article implies that it was part of the Windows 2003 Server SDK R2 release.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: patch

assuming this bug is still relavent.    This builds fine on try, not sure if I should check anything else

Review:

Comment 5

[Marco Zehe (:MarcoZ)]

The Win2K3R2 SDK is still needed if someone builds with an MSVC Express release which does not include ATL which in turn includes oleacc and other accessibility-related libraries and headers. Since W2K3R2 SDK is the oldest one we allow (and only as a dependent SDK on top of the Windows 7 SDK), if winable.h has been deprecated in that one, I'm sure we're not even using that ifdef any more.
I'm building with a VC++ express + Windows 7 SDK + Win2K3R2 SDK and this patch to see if I encounter any problems.

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 548460 [details] [diff] [review]
patch

Building, working. I assume we haven't used winable.h in our includes for years since that define never was true.

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #5)
> The Win2K3R2 SDK is still needed if someone builds with an MSVC Express
> release which does not include ATL which in turn includes oleacc and other
> accessibility-related libraries and headers.

Gecko accessibility doesn't require atl for years (see bug 325070). We use oleacc directly. The page https://developer.mozilla.org/en/atlbase.h states that accessibility only uses it and should be fixed. That makes Mozilla builds to not require Windows 2003 SDK longer.

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 548460 [details] [diff] [review]
patch

David, any specific reason why you asked me for additional review?

Comment 9

[Marco Zehe (:MarcoZ)]

But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC, but comes with the Professional editions of Visual Studio, but not the express editions of Visual C++. So for that, the Win2K3  R2 SDK is still required.

Comment 10

[alexander :surkov (:asurkov)]

(In reply to comment #9)
> But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC

it is, just checked it, oleacc.h and oleacc.lib are part of 7.0 SDK

Comment 11

[alexander :surkov (:asurkov)]

(In reply to comment #10)
> (In reply to comment #9)
> > But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC
> 
> it is, just checked it, oleacc.h and oleacc.lib are part of 7.0 SDK

I filed bug 674870 for this.

Comment 12

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/integration/mozilla-inbound/799636ad8a0d

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/799636ad8a0d