stop using deprecated winable.h, use winuser.h instead

RESOLVED FIXED in mozilla8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: beltzner, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla8
x86
Windows Vista
Points:
---
Bug Flags:
wanted-next +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

We now require the Windows Vista SDK, which no longer includes winable.h. According to MSDN (see URL) this library has been duplicated in winuser.h since January 2005. We should be using this library, instead.

This impacts people who are building on Windows, as after downloading the required SDKs, they need to source and manually add winable.h to get a working build with accessibility.
Flags: wanted-next+
Summary: stop using depricated winable.h, use winuser.h instead → stop using deprecated winable.h, use winuser.h instead

Comment 1

10 years ago
"January 2005" is which SDK release? The three SDKs in question are

* win2k3 SDK
* vista SDK (version 6.0)
* win2k8 SDK (version 6.1)
The MSDN article implies that it was part of the Windows 2003 Server SDK R2 release.
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → nobody

Updated

7 years ago
Blocks: 389800
(Assignee)

Comment 4

6 years ago
Created attachment 548460 [details] [diff] [review]
patch

assuming this bug is still relavent.    This builds fine on try, not sure if I should check anything else

Review:
(Assignee)

Updated

6 years ago
Attachment #548460 - Flags: review?

Comment 5

6 years ago
The Win2K3R2 SDK is still needed if someone builds with an MSVC Express release which does not include ATL which in turn includes oleacc and other accessibility-related libraries and headers. Since W2K3R2 SDK is the oldest one we allow (and only as a dependent SDK on top of the Windows 7 SDK), if winable.h has been deprecated in that one, I'm sure we're not even using that ifdef any more.
I'm building with a VC++ express + Windows 7 SDK + Win2K3R2 SDK and this patch to see if I encounter any problems.
Attachment #548460 - Flags: review?(surkov.alexander)
Attachment #548460 - Flags: review?
Attachment #548460 - Flags: review+

Comment 6

6 years ago
Comment on attachment 548460 [details] [diff] [review]
patch

Building, working. I assume we haven't used winable.h in our includes for years since that define never was true.
Attachment #548460 - Flags: feedback+

Comment 7

6 years ago
(In reply to comment #5)
> The Win2K3R2 SDK is still needed if someone builds with an MSVC Express
> release which does not include ATL which in turn includes oleacc and other
> accessibility-related libraries and headers.

Gecko accessibility doesn't require atl for years (see bug 325070). We use oleacc directly. The page https://developer.mozilla.org/en/atlbase.h states that accessibility only uses it and should be fixed. That makes Mozilla builds to not require Windows 2003 SDK longer.

Comment 8

6 years ago
Comment on attachment 548460 [details] [diff] [review]
patch

David, any specific reason why you asked me for additional review?
Attachment #548460 - Flags: review?(surkov.alexander)

Updated

6 years ago
Assignee: nobody → trev.saunders

Comment 9

6 years ago
But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC, but comes with the Professional editions of Visual Studio, but not the express editions of Visual C++. So for that, the Win2K3  R2 SDK is still required.

Comment 10

6 years ago
(In reply to comment #9)
> But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC

it is, just checked it, oleacc.h and oleacc.lib are part of 7.0 SDK

Comment 11

6 years ago
(In reply to comment #10)
> (In reply to comment #9)
> > But we still require oleacc.h, which is not part of the Windows 7 SDK IIRC
> 
> it is, just checked it, oleacc.h and oleacc.lib are part of 7.0 SDK

I filed bug 674870 for this.
(Assignee)

Comment 12

6 years ago
landed http://hg.mozilla.org/integration/mozilla-inbound/799636ad8a0d
http://hg.mozilla.org/mozilla-central/rev/799636ad8a0d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.