Closed
Bug 428759
Opened 17 years ago
Closed 17 years ago
No update throbber on OS X
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3
People
(Reporter: philor, Assigned: philor)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
2.53 KB,
patch
|
Gavin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Bug 397723 added loading_16.png and replaced loading_16.gif with loading_16.png in the jar.mn, but failed to remove the now-useless and unjarred loading_16.gif, and failed to look for callers outside browser/. The ones in lesser products I'm dealing with separately, but there are throbbers in extension update and update update too, that were also missed.
Attachment #315342 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•17 years ago
|
Keywords: regression
|
||
Comment 1•17 years ago
|
||
Comment on attachment 315342 [details] [diff] [review]
Fix v.1
grrrrrrrrrrrr!=me
Attachment #315342 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 2•17 years ago
|
||
I added a brief note to http://developer.mozilla.org/en/docs/Theme_changes_in_Firefox_3#Mac_OS_X (that doc will hopefully be cleaned up a bit at some point soon).
|
|
Assignee | |
Updated•17 years ago
|
Attachment #315342 -
Flags: approval1.9?
|
|
||
Comment 3•17 years ago
|
||
Kevin: please be careful to consider other toolkit users when making incompatible changes to the toolkit theme :)
Flags: blocking-firefox3?
|
||
Updated•17 years ago
|
Hardware: PC → All
Version: unspecified → Trunk
|
||
Updated•17 years ago
|
Attachment #315342 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
toolkit/themes/pinstripe/mozapps/extensions/update.css 1.4
toolkit/themes/pinstripe/mozapps/update/updates.css 1.7
toolkit/themes/pinstripe/global/icons/loading_16.gif delete
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
|
||
Comment 5•17 years ago
|
||
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko Minefield/3.0pre ID:2008041321
Doing a search for updates within the Extension Manager shows up the throbber again. Thanks.
Status: RESOLVED → VERIFIED
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
You need to log in
before you can comment on or make changes to this bug.
Description
•