Thunderbird startup leaks nsLocalFile due to bug 388833

RESOLVED FIXED

Status

Thunderbird
Build Config
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({mlk})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 315401 [details] [diff] [review]
The fix

Thunderbird leaks an nsLocaleFile (and conceivably its nsStringBuffer), probably due to bug 388833. According to my standalone-tinderbox I have been running we get these leaks on the Mail RLk test:

TOTAL                                           384       0.00%
nsLocalFile                                     360       0.00%
nsStringBuffer                                   24       0.00%

I picked the fix up after doing a bit of research and finding bug 389779 - basically we need to add a bit of code to nsMailApp.cpp to do things cleanly.

See attached patch, with this patch in, and the current form of the tinderbox tests, Mail RLk goes down to 0B for TB.

This probably accounts for some, but not all of the leaks in bug 426963 (yes we probably need to expand the tinderbox tests a bit more).
Attachment #315401 - Flags: superreview?(dmose)
Attachment #315401 - Flags: review?(dmose)

Comment 1

10 years ago
Yeah, it's a fictional leak, but since clean leak logs are good the extra loginit/logterm pair will get you where you want to be.

r=me, FWIW, though a mailnews peer should still give MOA.
(Assignee)

Comment 2

10 years ago
Comment on attachment 315401 [details] [diff] [review]
The fix

Moving review as dmose hasn't got privs in mail/ yet
Attachment #315401 - Flags: superreview?(dmose)
Attachment #315401 - Flags: review?(philringnalda)
Attachment #315401 - Flags: review?(dmose)
Comment on attachment 315401 [details] [diff] [review]
The fix

After careful study and long analysis, I believe what bsmedberg tells me ;)

r=philringnalda
Attachment #315401 - Flags: review?(philringnalda) → review+
(Assignee)

Comment 4

10 years ago
Patch checked in -> fixed.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.