428922 - Remove even more obsolete CSS rules

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Simon Paquet [:sipaq]]

Attachment: Patch v1

I went through our CSS files and this is what I found:

base/themes/*instripe/calendar-views.css
- textbox.editable-label

base/themes/*instripe/calendar-unifinder.css
- .calendar-unifinder-event-indent
- .unifinder-treecell-box-class

resources/skin/classic/dialogOverlay.css
- calendar-serverwindow

lightning/themes/*instripe/lightning.css
- calendar-todo-list {
- calendar-todo-list[disabled="true"]
- calendar-todo-item
- calendar-todo-item[selected="true"]
- view-title-label-box

sunbird/themes/*instripe/sunbird/calendar.css
- view-title-label-box

Comment 1

[Berend Cornelius]

Comment on attachment 315515 [details]
Patch v1

css rules are not used anymore - indeed. patch works fine: r=berend.

Comment 2

[Berend Cornelius]

When I looked at your patch I could see that there are also duplicately implemented rules in lightning.css and Sunbird's calendar.css. Maybe once you are at it you feel inclined to consolidate these rules. I think the calendar-views.css files would be appropriate locations for them.

This would be a good prerequisite to
  Bug 426979 – The appearance of the calendar grid should be improved
and for the consolidation of Sunbird's and lightning's code in general.

Comment 3

[Simon Paquet [:sipaq]]

Patch checked in.

Comment 4

[Simon Paquet [:sipaq]]

Berend, I filed bug 428933 for this and will supply I patch, once I get you on IRC for some answers.

Comment 5

[Andreas Treumann]

Checked in nightly build (Lightning 2008041418/Sunbird 2008014) -> task is fixed and verified.