Closed Bug 428933 Opened 16 years ago Closed 16 years ago

Consolidate view-specific CSS rules in calendar-views.css

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sipaq, Assigned: sipaq)

References

Details

Attachments

(1 file, 1 obsolete file)

As noted by Berend in bug 428922 comment 2, we still duplicate many view-specific CSS rules in lightning.css (Lightning) and calendar.css (Sunbird). Those rules should be consolidated.
Flags: wanted-calendar0.9+
Attached patch Patch v1 (obsolete) — Splinter Review
The patch is ready as far as I can tell.
Attachment #315536 - Flags: review?(Berend.Cornelius)
Your patch threw a warning at the rule .tooltipBody
The following adaption resolved it:

description.tooltipBody {
  font-weight: normal;
  white-space: -moz-pre-wrap;
  margin: 0pt;
}
For further information please see (in german)
http://www.css4you.de/Texteigenschaften/white-space.html

>+/* Alarm image */
>.alarm-image {

I find this comment superfluous

While you are at it you could maybe also shift the image files "prevnextarrows.png"to the calendar/base/themes/*instripe/folders and adapt the according entries in the jar.mn files.
Besides that the patch worked fine. It was bitrotten and I will attach an unbitrotted one.
Comment on attachment 315536 [details] [diff] [review]
Patch v1

patch generally works fine; r=berend;
Attachment #315536 - Flags: review?(Berend.Cornelius)
Attachment #315536 - Attachment is obsolete: true
Unbitrotted patch checked in, combined with a move of prevnextarrow.png to base/themes and according jar.mn changes.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: