428933 - Consolidate view-specific CSS rules in calendar-views.css

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Simon Paquet [:sipaq]]

As noted by Berend in bug 428922 comment 2, we still duplicate many view-specific CSS rules in lightning.css (Lightning) and calendar.css (Sunbird). Those rules should be consolidated.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: Patch v1

The patch is ready as far as I can tell.

Comment 2

[Berend Cornelius]

Your patch threw a warning at the rule .tooltipBody
The following adaption resolved it:

description.tooltipBody {
  font-weight: normal;
  white-space: -moz-pre-wrap;
  margin: 0pt;
}
For further information please see (in german)
http://www.css4you.de/Texteigenschaften/white-space.html

>+/* Alarm image */
>.alarm-image {

I find this comment superfluous

While you are at it you could maybe also shift the image files "prevnextarrows.png"to the calendar/base/themes/*instripe/folders and adapt the according entries in the jar.mn files.
Besides that the patch worked fine. It was bitrotten and I will attach an unbitrotted one.

Comment 3

[Berend Cornelius]

Comment on attachment 315536 [details] [diff] [review]
Patch v1

patch generally works fine; r=berend;

Comment 4

[Berend Cornelius]

Attachment: unbitrotted patch

Comment 5

[Simon Paquet [:sipaq]]

Unbitrotted patch checked in, combined with a move of prevnextarrow.png to base/themes and according jar.mn changes.