Closed
Bug 428924
Opened 17 years ago
Closed 17 years ago
Windows icon: library window navigation icons can not reference toolbar.png anymore
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: faaborg, Assigned: dao)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.70 KB,
patch
|
asaf
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
libraryNavigation.png
Previously the navigation buttons in the library window have been located in toolbar.png. We are switching the icons in toolbar.png to be round so that they look correct when the user is in icons + text mode. The navigation icons for the library window will be:
/winstripe/browser/places/libraryNavigation.png
/winstripe/browser/places/libraryNavigation-aero.png
This files will be included in the next icon drop. I'll update this bug when they have landed.
|
Reporter | |
Updated•17 years ago
|
Summary: Library window navigation icons can not reference toolbar.png anymore → Windows icon: library window navigation icons can not reference toolbar.png anymore
|
||
Comment 1•17 years ago
|
||
Alex: what will the dimensions and image format be?
Mano: can you patch the appropriate CSS for this?
Flags: blocking-firefox3+
|
|
Reporter | |
Comment 2•17 years ago
|
||
|
|
Reporter | |
Comment 3•17 years ago
|
||
|
|
Reporter | |
Comment 4•17 years ago
|
||
Land these two icons to /winstripe/browser/places
|
||
Updated•17 years ago
|
Assignee: nobody → mano
Target Milestone: --- → Firefox 3
|
||
Comment 5•17 years ago
|
||
I'll find an owner for this, Mano's got a ton on his plate already.
Assignee: mano → mconnor
|
Assignee | |
Comment 7•17 years ago
|
||
Attachment #315915 -
Attachment is obsolete: true
Attachment #315916 -
Attachment is obsolete: true
Attachment #316579 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•17 years ago
|
Attachment #316579 -
Flags: review?(gavin.sharp) → review?(dietrich)
|
|
||
Comment 8•17 years ago
|
||
Comment on attachment 316579 [details] [diff] [review]
patch
r=mano
Attachment #316579 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #316579 -
Flags: approval1.9?
|
|
||
Comment 9•17 years ago
|
||
Comment on attachment 316579 [details] [diff] [review]
patch
a=mconnor on behalf of 1.9 drivers
Attachment #316579 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [has patch][has reviews]
|
||
Comment 10•17 years ago
|
||
mozilla/browser/themes/winstripe/browser/places/organizer.css 1.12
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews]
|
||
Comment 11•17 years ago
|
||
Why is the new image not a chrome URL, like all others in organizer.css?
|
|
Assignee | |
Comment 12•17 years ago
|
||
URLs in a CSS file are relative to that file by default, which makes the path redundant in this case. Is there anything wrong with that?
|
|
||
Comment 13•17 years ago
|
||
(In reply to comment #12)
> URLs in a CSS file are relative to that file by default, which makes the path
> redundant in this case. Is there anything wrong with that?
>
Nah, just wondering. I don't know about coding style in the theme and consistency rules, though.
You need to log in
before you can comment on or make changes to this bug.
Description
•