429009 - Change "MacOSX" to "Mac OS X" for the Mac-only install buttons?

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Administration, defect, P5)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Change "MacOSX" to "Mac OS X" for the Mac-only install buttons?

The platform-specific install button for Mac OS X reads, "Add to Firefox (MacOSX)"

Other platform-specific buttons read "Add to Firefox (Windows)" and "Add to Firefox (Linux)".

Fred tells me it's a non-trivial change to do:

s/MacOSX/Mac OS X (or just s/MacOSX/Mac)

Comment 1

[Fred Wenzel [:wenzel]]

Technical note: We need to make sure the change doesn't break anything, and when I tried it on my local copy, platforms part of the dev CP hit PHP's memory limit. This may be CakePHP being greedy.

Anyhow even if the string change doesn't break anything (which I hope), we still either need to push code changes to the localizer CP to fix the memory limit thing, or run SQL to get the change in.

Comment 2

[Ambrose Li]

This definitely should not be changed to "Mac OS X" even if it doesn't break anything; the OS is called "MacOS X", not "Mac OS X".

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> This definitely should not be changed to "Mac OS X" even if it doesn't break
> anything; the OS is called "MacOS X", not "Mac OS X".

Interesting, particularly because Apple disagrees: http://www.apple.com/macosx/

Comment 4

[Wil Clouser [:clouserw]]

another technical side note I stubled on while fixing another bug: this breaks install buttons because "macosx" is echoed out as part of the id of the element.

Comment 5

[Michael Morgan [:morgamic]]

NO!

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

MEOW!

Comment 7

[Jesse Ruderman]

Why was this marked as invalid?  "Mac OS X" is clearly the correct spelling...

Comment 8

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> Why was this marked as invalid?

I think Mike wanted to WONTFIX it instead.

Comment 9

[Jesse Ruderman]

That makes more sense, but should still come with a reason.

Comment 10

[Wil Clouser [:clouserw]]

Ryan:  is comment 4 fixed with your awesome new buttons?  If so this is probably trivial to fix

Comment 11

[Ryan Doherty (:rdoherty)]

(In reply to comment #10)
> Ryan:  is comment 4 fixed with your awesome new buttons?  If so this is
> probably trivial to fix

Hmm, I don't think it is afaict. I wouldn't be too hard to fix regardless.

Comment 12

[Wil Clouser [:clouserw]]

We'll fix this in zamboni

Comment 13

[Fred Wenzel [:wenzel]]

(In reply to comment #12)
> We'll fix this in zamboni

We have.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot, ZOMG

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.