429029 - Right click on WMP plugin and Properties or Options doesn't work

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041406 Minefield/3.0pre ID:2008041406

1. New profile, start firefox
2. Go to http://www.gametrailers.com/player/32661.html?type=wmv
3. Wait for the WMP plugin to appear and right click on the plugin to get the plugin's context menu
4. Select menu item "Properties" or "Options"

Expected:
- A WMP-related dialog appears

Actual:
- It looks like the dialog appears and then disappears really quickly for no apparent reason

Works: 20080407_2058_firefox-3.0pre.en-US.win32
Broken: 20080408_0216_firefox-3.0pre.en-US.win32

Checkins to module PhoenixTinderbox between 2008-04-07 20:58 and 2008-04-08 02:16 :
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-07+20%3A58&maxdate=2008-04-08+02%3A16&cvsroot=%2Fcvsroot

Comment 1

[Steve England [:stevee]]

I'm using npdisplay.dll v3.0.2.629 apparently.

Comment 2

[Martijn Wargers (dead)]

Backing out the patch for bug 427259 seems to fix this.

Comment 3

[Marco Zehe (:MarcoZ) [out sick]]

Looks like this plugin looks for a MozillaDialogClass.  Since the change fixes a ton of problems with screen readers (and a regression from Firefox 2.0), is it possible to work with the plugin developers to not depend on the MozillaDialogClass string?

Comment 4

[Marco Zehe (:MarcoZ) [out sick]]

Fixed by backout of bug 427259.
Checking in widget/src/windows/nsWindow.h;
/cvsroot/mozilla/widget/src/windows/nsWindow.h,v  <--  nsWindow.h
new revision: 3.253; previous revision: 3.252
done

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041506 Minefield/3.0pre