429093 - Add margin to Event List for Today Pane

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Christian Jansen]

Attachment: mock-up showing event list with margin

see attachment

Comment 1

[Simon Paquet [:sipaq]]

--> me

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Screenshot of fixed bug (Windows) for UI review

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 316712 [details] [diff] [review]
Patch v1

I personally think 5px is a bit much, 3px maybe. But thats up to Christian.

r=philipp

Comment 5

[Simon Paquet [:sipaq]]

Philipp, I used 5px as this is the same value that is used for the miniday and Christian wants both (miniday and event list) vertically aligned.

Comment 6

[Christian Jansen]

Looks OK, but I agree 3px would look better. Simon could reduce the margin of the Mini-Day and the Event List to 3px? Thanks. ui+ with that change.

Comment 7

[Simon Paquet [:sipaq]]

Comment on attachment 316714 [details]
Screenshot of fixed bug (Windows) for UI review

Setting to review+ per comment 6.

Comment 8

[Simon Paquet [:sipaq]]

Patch checked in on HEAD and MOZILLA_1_8_BRANCH with 3px margin as requested by reviewers.

Comment 9

[Stefan Sitter [:ssitter]]

Simon, is it on purpose that the background of the navigation bar above the main calendar view was removed too? 

In Sunbird it's still set to white but in Lightning it's white or black or gray or ... dependent on the Windows theme. I can imagine that the blue button text is not readable if the background happens to be bluish too.

Comment 10

[Simon Paquet [:sipaq]]

Stefan, I don't understand your comment here. I assume you wanted to post it to bug 429101?

Comment 11

[Stefan Sitter [:ssitter]]

Sorry for confusion, maybe I shouldn't post that late. Seems the issue already exists in older Lightning releases.

Comment 12

[Andreas Treumann]

Checked in lightning build 2008062703 -> VERIFIED