Closed
Bug 429151
Opened 17 years ago
Closed 17 years ago
Remove version checking for added microformats
Categories
(Toolkit Graveyard :: Microformats, defect)
Toolkit Graveyard
Microformats
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
|
2.21 KB,
patch
|
sayrer
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
When I first did microformats for Operator, things were in flux so I added an internal version that got checked before a new microformat was added.
This version actually makes things more confusing in the current code, and I believe the code is "baked" enough that if major changes were made that then required major changes in the microformats API, we would be able to check for those changes rather than requiring internal versions in the added microformats.
Attachment #315795 -
Flags: review?(sayrer)
Updated•17 years ago
|
Attachment #315795 -
Flags: review?(sayrer) → review+
| Assignee | ||
Comment 1•17 years ago
|
||
Comment on attachment 315795 [details] [diff] [review]
Remove versioning code
This change does not affect existing code paths. It's about extensibility and making it easier for people to write new microformats by not having to worry about internal versions.
Attachment #315795 -
Flags: approval1.9?
After trying to use the API with the internal version number in place, I applaud this decision. I think it will make it much easier for extension authors who wish to add new microformats to use our API. This is something that should really go into Firefox 3.
Comment 3•17 years ago
|
||
Comment on attachment 315795 [details] [diff] [review]
Remove versioning code
a1.9=beltzner
Attachment #315795 -
Flags: approval1.9? → approval1.9+
| Assignee | ||
Comment 4•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•