Closed Bug 429151 Opened 17 years ago Closed 17 years ago

Remove version checking for added microformats

Categories

(Toolkit Graveyard :: Microformats, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

When I first did microformats for Operator, things were in flux so I added an internal version that got checked before a new microformat was added. This version actually makes things more confusing in the current code, and I believe the code is "baked" enough that if major changes were made that then required major changes in the microformats API, we would be able to check for those changes rather than requiring internal versions in the added microformats.
Attachment #315795 - Flags: review?(sayrer)
Attachment #315795 - Flags: review?(sayrer) → review+
Comment on attachment 315795 [details] [diff] [review] Remove versioning code This change does not affect existing code paths. It's about extensibility and making it easier for people to write new microformats by not having to worry about internal versions.
Attachment #315795 - Flags: approval1.9?
After trying to use the API with the internal version number in place, I applaud this decision. I think it will make it much easier for extension authors who wish to add new microformats to use our API. This is something that should really go into Firefox 3.
Comment on attachment 315795 [details] [diff] [review] Remove versioning code a1.9=beltzner
Attachment #315795 - Flags: approval1.9? → approval1.9+
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: