Expose ROLE_DOCUMENT for ARIA landmarks that inherit from document

VERIFIED FIXED in mozilla1.9.1a1

Status

()

Core
Disability Access APIs
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla1.9.1a1
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: post1.9[has-patch,has-review])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
At least 1 ARIA landmark inherits from "document" -- it's role="article".

For the ATK/MSAA enumerated roles we are supposed to expose the closest role. In this case that would be ROLE_DOCUMENT.

I'll have to check to see if there are other sitatuons like this.
(Assignee)

Comment 1

9 years ago
Created attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT

There are no other descendant roles for document.
Attachment #316809 - Flags: review?(marco.zehe)

Comment 2

9 years ago
Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT

r=me
Attachment #316809 - Flags: review?(marco.zehe) → review+
(Assignee)

Updated

9 years ago
Attachment #316809 - Flags: approval1.9?
Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT

Tests?  Explanation of risk?  Re-request approval once addressed.
Attachment #316809 - Flags: approval1.9? → approval1.9-
(Assignee)

Updated

9 years ago
Whiteboard: post1.9

Updated

9 years ago
Blocks: 391535

Updated

9 years ago
Whiteboard: post1.9 → post1.9[has-patch,has-review]

Comment 4

9 years ago
Aaron, is there a test page I could use for a Mochitest for this one?
(Assignee)

Comment 5

9 years ago
Created attachment 324597 [details]
Testcase: just use role="article"

Comment 6

9 years ago
Created attachment 325233 [details] [diff] [review]
Patch containing both original patch and Mochitest

Original patch by Aaron, this also contains a Mochitest for it.
Attachment #324597 - Attachment is obsolete: true
Attachment #325233 - Flags: review?(surkov.alexander)

Comment 7

9 years ago
Comment on attachment 325233 [details] [diff] [review]
Patch containing both original patch and Mochitest

r=me.
Though I would suggest to call the file as "test_aria_role_article". We have already the file (test_aria_activedescendant). It should be easier to find out that file and extend test in the future.
Attachment #325233 - Flags: review?(surkov.alexander) → review+

Comment 8

9 years ago
Pushed in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cc03e7e0747b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

Comment 9

9 years ago
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008062603 Minefield/3.1a1pre
Status: RESOLVED → VERIFIED

Updated

9 years ago
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.