429688 - Add a Reporter icon to Toolbar.png

Status: VERIFIED WONTFIX

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The keyhole has moved position in the toolbar files due to the inclusion of the report site icon, and due to some minor changes to the alignment with the etch.  I'll attach the new files.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-aero.png

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar.png

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-small-aero.png

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-small.png

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-aero.png

No change to layout

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-small-aero.png

No change to layout.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-small.png

No change to layout.

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar.png

No change to layout.

Comment 9

[Dão Gottwald [:dao]]

The reporter is an extension with its own theme files:
http://mxr.mozilla.org/seamonkey/source/extensions/reporter/resources/skin/classic/reporter/

Comment 10

[Dão Gottwald [:dao]]

I think we should just land the updated Toolbar.png files without the Reporter icon and wontfix this bug.
Overriding the Reporter's styling in browser.css would be possible but seems like bad practice. The current icon isn't that bad, so we should we bother? (Who uses that toolbar button anyway? Can it be removed from Reporter?)

Comment 11

[Reed Loden [:reed]]

Also see bug 409287.

Comment 12

[Dão Gottwald [:dao]]

So, bug 409287 comment 5 points out that we can't override all image regions from Reporter's stylesheet.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, I know from Alex that he want to push the new home button icon with this bug. So why this bug is about the reporter icon now?

Comment 14

[Dão Gottwald [:dao]]

There shouldn't be any CSS changes needed for the updated Home icon.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Ryan: I think you and Gavin had worked out a way to do the override properly here, can you help?

(In reply to comment #10)
> like bad practice. The current icon isn't that bad, so we should we bother?
> (Who uses that toolbar button anyway? Can it be removed from Reporter?)

The current icon doesn't match the visual style of all the other icons which we've taken great pains to get right. If we have done all that work such that someone opening the customize palette sees a bunch of icons that look like they fit in together, we should try to include them. Let's work on solutions, when they are possible, instead of talking about all the reasons we can't do something.

Comment 16

[Dão Gottwald [:dao]]

I am suggesting that we do something: Remove the toolbar button. That would do a better service to the customization experience.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #12)
> So, bug 409287 comment 5 points out that we can't override all image regions
> from Reporter's stylesheet.

We can change reporter to not use !important and instead use :not() selectors.

Comment 18

[Dão Gottwald [:dao]]

Yeah, I'm sure there are ways to do this. We could also ship an image with the same dimensions and don't override the regions at all.

Yet it seems that this icon is the least important one that one could ever think of.
Overriding the Adblock Plus icon would probably affect more users.

Can somebody make a point why the Reporter button isn't old cruft and should be kept?

Comment 19

[Dão Gottwald [:dao]]

(In reply to comment #18)
> Can somebody make a point why the Reporter button isn't old cruft and should be
> kept?

Apparently nobody so far. I filed bug 430217.

Comment 20

[Alex Faaborg [:faaborg] (Firefox UX)]

>Can somebody make a point why the Reporter button isn't old cruft and should be
>kept?

I agree that it is crufty. Safari currently has one, but then again webkit has a lot more compatibility problems.   I'm personally fine with removing it, but if we do keep it I want us to theme it for each platform.  We already have the icons created for OS X, Tango, XP and Vista.  I don't really care where the image files end up landing, I would just like to make sure each platform has a consistent look.  The previous reporter icon in the customization palette of proto is particularly jarring.  Note that they have created a new icon in their toolbar.png as well:

http://mxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/Toolbar.png

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

We're keeping it because there is a hope that we'll be able to continue to improve reporter to the point where we can put that button on the toolbar by default in betas as a way of encouraging more feedback. I suppose we could remove it for now and put it back in at that point.

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

BTW, ftr, morphing this bug to be about the toolbar was the wrong thing to do. I don't want to argue more about it, but it made it impossible for drivers (or at least me) to understand that there was more to the original request than just adding in a reporter icon - as a result, we're now behind on modifying the CSS required to get changes to the keyhole shape in.

One hopes you'll try to help us move forward in bug 430834, instead.

Comment 23

[Mike Connor [:mconnor]]

(by which he means bug 430384)

Comment 24

[Ed Hume]

(In reply to comment #21)
> We're keeping it because there is a hope that we'll be able to continue to
> improve reporter to the point where we can put that button on the toolbar by
> default in betas as a way of encouraging more feedback. I suppose we could
> remove it for now and put it back in at that point.
> 
Out of respect to the various themers who have skinned this button, it would be polite of you - when you bring this button back - to leave the ID the same so that themers will not have to make unnecessary changes to themes.

Comment 25

[Robert Accettura [:raccettura]]

(In reply to comment #24)
> Out of respect to the various themers who have skinned this button, it would be
> polite of you - when you bring this button back - to leave the ID the same so
> that themers will not have to make unnecessary changes to themes.
> 

Reasonable request.  Don't see why we wouldn't.