Closed Bug 430217 Opened 13 years ago Closed 13 years ago

Reporter shouldn't add a toolbar button to Firefox

Categories

(Other Applications Graveyard :: Reporter, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.9

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: late-l10n, ue)

Attachments

(1 file)

Attached patch patchSplinter Review
The toolbar button that Reporter specifies for Firefox seems rather useless (as opposed to the Help menu item). I suspect it's very rarely used, if at all. It clutters the Customization palette by causing a scroll bar (Win XP, fresh profile) and it's hard to theme at the moment (bug 429688, bug 409287). I think we should remove it.
Flags: blocking1.9?
Attachment #316962 - Flags: review?(robert)
Blocks: 419231
(In reply to comment #0)
> It clutters the Customization palette by causing a scroll bar

--> bug 419231
It seems that the toolbar button dates back to when the Reporter was enabled in nightlies only (bug 285653) and when significantly more sites were broken in Gecko. I guess the button made sense at that time.
Comment on attachment 316962 [details] [diff] [review]
patch

It was implemented for a few reasons:

1.  Safari did it.  "Apple Knows Best".

2.  There was a thought to enable it on nightly builds to appear  by default, and for release builds to not be on the toolbar by default.  I don't think we ever actually hooked this up, as it was to late in the 1.5 release cycle when reporter was hooked up, and it never happened in the 2.0 era.  At least that's how I recall it.

3.  It was requested a few times when reporter was only available as an extension (and I hosted the reporter server personally) during very early beta's.  

I personally don't think it's used much, and don't mind it being removed.  I'm not sure if anyone else should chime in.

Code wise, looks good to me.

r=raccettura
Attachment #316962 - Flags: review?(robert) → review+
Attachment #316962 - Flags: ui-review?(beltzner)
Attachment #316962 - Flags: ui-review?(beltzner)
Attachment #316962 - Flags: ui-review+
Attachment #316962 - Flags: approval1.9+
Wouldn't hold the release for this. Re-nom if you disagree completely.
Flags: wanted1.9.0.x+
Flags: blocking1.9?
Flags: blocking1.9-
Damon: On Mac the icon looks really out of place in the toolbar because it is not styled and the test of the icons are all greyscale. Since we are advertising a visual refresh, I think it should either be removed or restyled before we ship, but because it looks like the restyling will not happen I would advocate removing this icon for final ship so that the customize toolbar palette looks correct on Mac. Note that I am not against the concept of having a toolbar icon, but if this is the best we can for final I would vote for it.
Flags: blocking1.9- → blocking1.9?
mozilla/extensions/reporter/jar.mn 	1.10
mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd 	1.6
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.xul 	1.12
mozilla/extensions/reporter/resources/skin/classic/reporter/browserOverlay.css delete
mozilla/extensions/reporter/resources/skin/classic/reporter/reporter-icon-large.png delete
mozilla/extensions/reporter/resources/skin/classic/reporter/reporter-icon-small.png delete
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Sob. Why are we removing strings now?
Keywords: late-l10n
Why is removing strings a problem?
(In reply to comment #7)
> Sob. Why are we removing strings now?

Sorry, I should have noticed that. Is it worth reverting that change at this point?
>Is it worth reverting that change at this point?

If we add the icon back, and we theme it correctly inside the reporter extension for proto, tango and strata?
(In reply to comment #10)
> >Is it worth reverting that change at this point?
> 
> If we add the icon back, and we theme it correctly inside the reporter
> extension for proto, tango and strata?

Sounds like Firefox v.next stuff to me.
We have all of the icons, I think we need to either

-remove the button
-update the icons

Keeping the old icons given that we updated everything else will make the product look sloppy.
(In reply to comment #10)
> >Is it worth reverting that change at this point?
> 
> If we add the icon back, and we theme it correctly inside the reporter
> extension for proto, tango and strata?

I meant just the string changes (leaving the strings instead of removing them).
-'ing per comment 11.
Flags: blocking1.9? → blocking1.9-
No longer blocks: 419231
Button removed.  Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre.
Status: RESOLVED → VERIFIED
Flags: wanted1.9.0.x+
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.