430217 - Reporter shouldn't add a toolbar button to Firefox

Status: VERIFIED FIXED

(Other Applications Graveyard :: Reporter, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

The toolbar button that Reporter specifies for Firefox seems rather useless (as opposed to the Help menu item). I suspect it's very rarely used, if at all. It clutters the Customization palette by causing a scroll bar (Win XP, fresh profile) and it's hard to theme at the moment (bug 429688, bug 409287). I think we should remove it.

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> It clutters the Customization palette by causing a scroll bar

--> bug 419231

Comment 2

[Dão Gottwald [:dao]]

It seems that the toolbar button dates back to when the Reporter was enabled in nightlies only (bug 285653) and when significantly more sites were broken in Gecko. I guess the button made sense at that time.

Comment 3

[Robert Accettura [:raccettura]]

Comment on attachment 316962 [details] [diff] [review]
patch

It was implemented for a few reasons:

1.  Safari did it.  "Apple Knows Best".

2.  There was a thought to enable it on nightly builds to appear  by default, and for release builds to not be on the toolbar by default.  I don't think we ever actually hooked this up, as it was to late in the 1.5 release cycle when reporter was hooked up, and it never happened in the 2.0 era.  At least that's how I recall it.

3.  It was requested a few times when reporter was only available as an extension (and I hosted the reporter server personally) during very early beta's.  

I personally don't think it's used much, and don't mind it being removed.  I'm not sure if anyone else should chime in.

Code wise, looks good to me.

r=raccettura

Comment 4

[Damon Sicore (:damons)]

Wouldn't hold the release for this. Re-nom if you disagree completely.

Comment 5

[Marcia Knous [:marcia]]

Damon: On Mac the icon looks really out of place in the toolbar because it is not styled and the test of the icons are all greyscale. Since we are advertising a visual refresh, I think it should either be removed or restyled before we ship, but because it looks like the restyling will not happen I would advocate removing this icon for final ship so that the customize toolbar palette looks correct on Mac. Note that I am not against the concept of having a toolbar icon, but if this is the best we can for final I would vote for it.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/extensions/reporter/jar.mn 	1.10
mozilla/extensions/reporter/locales/en-US/chrome/reporterOverlay.dtd 	1.6
mozilla/extensions/reporter/resources/content/reporter/reporterOverlay.xul 	1.12
mozilla/extensions/reporter/resources/skin/classic/reporter/browserOverlay.css delete
mozilla/extensions/reporter/resources/skin/classic/reporter/reporter-icon-large.png delete
mozilla/extensions/reporter/resources/skin/classic/reporter/reporter-icon-small.png delete

Comment 7

[Axel Hecht [:Pike]]

Sob. Why are we removing strings now?

Comment 8

[Dão Gottwald [:dao]]

Why is removing strings a problem?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> Sob. Why are we removing strings now?

Sorry, I should have noticed that. Is it worth reverting that change at this point?

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

>Is it worth reverting that change at this point?

If we add the icon back, and we theme it correctly inside the reporter extension for proto, tango and strata?

Comment 11

[Reed Loden [:reed]]

(In reply to comment #10)
> >Is it worth reverting that change at this point?
> 
> If we add the icon back, and we theme it correctly inside the reporter
> extension for proto, tango and strata?

Sounds like Firefox v.next stuff to me.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

We have all of the icons, I think we need to either

-remove the button
-update the icons

Keeping the old icons given that we updated everything else will make the product look sloppy.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> >Is it worth reverting that change at this point?
> 
> If we add the icon back, and we theme it correctly inside the reporter
> extension for proto, tango and strata?

I meant just the string changes (leaving the strings instead of removing them).

Comment 14

[Damon Sicore (:damons)]

-'ing per comment 11.

Comment 15

[Tony Chung [:tchung]]

Button removed.  Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre.