429924 - IceWeasel not getting Install Link correctly

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[steviex]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9b5) Gecko/2008041514 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080311 Iceweasel/2.0.0.13 (Debian-2.0.0.13-0etch1) 

When Using IceWeasel(Debian version of Firefox) Addons will not give the Install link, It gives a Download link instead

Reproducible: Always

Steps to Reproduce:
1. Alter User Agent to IceWeasel Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080311 Iceweasel/2.0.0.13 (Debian-2.0.0.13-0etch1) 
2.Go to https://addons.mozilla.org/en-US/firefox/

Actual Results:  
Download Now appears in Green Box

Expected Results:  
It should be Install Now.

Comment 1

[Fred Wenzel [:wenzel]]

While it's technically possible, I am unsure if we should add unofficial flavors of Firefox to the UA detection code, thus leading to their support in some parts of the page but not in others.

CCing Basil for clarification.

Comment 2

[steviex]

This user asked the question in MozillaZine... http://forums.mozillazine.org/viewtopic.php?t=649852&highlight=

Comment 3

[steviex]

According to the User on the above thread, unless he changes the user Agent to Firefox, IceWeasel will just Download the .xpi rather than trigger an Install.

This will affect users using Debian, Knoppix and other Linux Distros that get IceWeasel from Debian.

I guess this will also affect the Debian version of SeaMonkey (IceApe) too... 

Comment 4

[Samuel Bronson]

Perhaps you shouldn't be using user-agent fields to determine whether the browser is appropriate?

Comment 5

[Samuel Bronson]

(In reply to comment #4)
> Perhaps you shouldn't be using user-agent fields to determine whether the
> browser is appropriate?
... especially in view of bug 334967.

Comment 6

[Philip Chee]

> ... especially in view of bug 334967.

Irrelevant. Browser sniffing here is necessary.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Bug 334967 is not relevant here, for the reasons explained in bug 334967 comment 22.

Comment 8

[Basil Hashem [:baz]]

Our policy on AMO is that we do not support IceWeasel & IceApe - they are not official browsers in our support matrix. But, we will make an exception and make a small modification to our browser detection code so that "Add to Firefox"/"Add to SeaMonkey" buttons will appear instead of "Download Now". No other modifications will be made.

Comment 9

[Fred Wenzel [:wenzel]]

Code change is in r12465.

Comment 10

[steviex]

Thank you Kind sirs :) Well done.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #9)
> Code change is in r12465.

The fix doesn't work, because the actual user-agent string has "Iceweasel" lower-cased: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061024 Iceweasel/2.0 (Debian-2.0+dfsg-1)

Just do s/IceWeasel/Iceweasel, and it works :-)

Comment 12

[Fred Wenzel [:wenzel]]

Meh. Thanks, stephend. Will do that. What about IceApe vs. Iceape?

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #12)
> Meh. Thanks, stephend. Will do that. What about IceApe vs. Iceape?

"Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.13pre) Gecko/20070505 Iceape/1.0.9"

Comment 14

[steviex]

My bad for causing the confusion :oops: I should have used the same capitalisation in the names as in the User Agent. Sorry for causing the confusion...

Comment 15

[Fred Wenzel [:wenzel]]

(In reply to comment #14)
> My bad for causing the confusion :oops: I should have used the same
> capitalisation in the names as in the User Agent. Sorry for causing the
> confusion...

No worries, I should have checked the correct spelling before committing.

Thanks, stephend, for finding this. The fix in SVN, r12532.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, yay!  Iceape gets treated as "SeaMonkey", and "Iceweasel" gets treated as "Firefox"--both display their respective "Add to SeaMonkey" and "Add to Firefox" installTrigger buttons.