430435 - Differences in ebay.in plugins

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Axel Hecht [:Pike]]

Attachment: diffing ebay-in's against gu-IN version

Hi,

we currently have 5 eBay India plugins in the tree, two of which differ from the others, namely the ones for bn-IN and ml.

For Bengali, the encoding changed from latin-1 to utf-8, that actually sounds like a good change to make. The <Image> change on the other hand seems to be wrong, bad mime type, and crufty icon. The icons don't seem to be too good across all versions, the en-US version that we have right now seems best, data:image/x-icon;base64,AAABAAEAEBAAAAEACABoBQAAFgAAACgAAAAQAAAAIAAAAAEACAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAQAAAAIAAAADAAAAA/wAAAABAAABAQAAAgEAAAMBAAAD/QAAAAIAAAECAAACAgAAAwIAAAP+AAAAAwAAAQMAAAIDAAADAwAAA/8AAAAD/AABA/wAAgP8AAMD/AAD//wAAAABAAEAAQACAAEAAwABAAP8AQAAAQEAAQEBAAIBAQADAQEAA/0BAAACAQABAgEAAgIBAAMCAQAD/gEAAAMBAAEDAQACAwEAAwMBAAP/AQAAA/0AAQP9AAID/QADA/0AA//9AAAAAgABAAIAAgACAAMAAgAD/AIAAAECAAEBAgACAQIAAwECAAP9AgAAAgIAAQICAAICAgADAgIAA/4CAAADAgABAwIAAgMCAAMDAgAD/wIAAAP+AAED/gACA/4AAwP+AAP//gAAAAMAAQADAAIAAwADAAMAA/wDAAABAwABAQMAAgEDAAMBAwAD/QMAAAIDAAECAwACAgMAAwIDAAP+AwAAAwMAAQMDAAIDAwADAwMAA/8DAAAD/wABA/8AAgP/AAMD/wAD//8AAAAD/AEAA/wCAAP8AwAD/AP8A/wAAQP8AQED/AIBA/wDAQP8A/0D/AACA/wBAgP8AgID/AMCA/wD/gP8AAMD/AEDA/wCAwP8AwMD/AP/A/wAA//8AQP//AID//wDA//8A////AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAB8fHx8fHx8fHx8fHx8AAB8cGRkUFAcHBx8fBUKfAAAfFBkfHxNHF4cb29vCnwAAHxkZFBQUBx8HG98bwp8fAB8ZGR8UGQcXhxvb28KFXx8fHZkZGRNHBwcfG8jCgoQfAB8fHx8HBx8b29vCnwPCnwAAAB8fBwcfHx8EBB8Dwp8AAAAAHx8fHwAfHx8AHx8fAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAP//AAD//wAA//8AAP//AACAAwAAAAMAAAADAAAAAQAAAAAAAAAAAACAAAAA4AAAAPCIAAD//wAA//8AAP//AAA=

(page zoom in fx3 to the max to see the differences)

bn added a <Param name="sourceid" value="Mozilla-search"/>, too, which isn't what we usually use for ebay.

ml has a change to the ShortName, from eBay to "eBay India".

Both search ebay.in rather than ebay.co.in, which is probably cool, not sure which would be better.

The reason for this bug is that if we only needed one version, that'd be easier to maintain.

I attached a diff of all plugins against the gu-IN one, which is likely the oldest one (if it's not the pa-IN, the two are the same).

CCed all owners, too.

Mic, further comments?

Comment 1

[Mic Berman]

agree on using icon from en-US given what you've described above. searching ebay.in i think is better because ebay.co.in redirects (for me anyway) to ebay.in
 

Comment 2

[Axel Hecht [:Pike]]

Any comments here from our localizers?

Comment 3

[Joyce K Babu]

I used "eBay India", because the title of ebay.in says so. But everywhere else they are using the name "eBay". Still I suggest "eBay India", so that users who install both the US and Indian version can distinguish between the two.

And as Mic said, ebay.co.in redirects to ebay.in and the logo on the site also shows "eBay.in". So, I think we should use ebay.in as the domain.

Comment 4

[Mic Berman]

sounds like good rationale to me. i can ask ebay what they want if we want?

Comment 5

[Ankit Patel]

After looking ebay-in.xml file closely, I found four important things with it:
1. <ShortName>eBay India</ShortName> is better than <ShortName>eBay</ShortName>
2. <InputEncoding>UTF-8</InputEncoding> is better than <InputEncoding>ISO-8859-1</InputEncoding>
3. template="http://search.ebay.in/search/search.dll"> is better than template="http://search.ebay.co.in/search/search.dll">
4. <Image width="16" height="16">data:image/x-icon; is changed to <Image width="16" height="16">data:image/x-ico; in bn-IN, which should be corrected I think.

Let's know, what you decide on these. So, we can make the changes accordingly in respective indic languages...

Comment 6

[Axel Hecht [:Pike]]

Attachment: eBay India plugin as discussed

I copied over the en-US ebay plugin and adjusted the urls from ebay.com to ebay.in, changed the encoding and the short name.

Tested locally with german umlauts, which roundtrip right. Küken are not up on ebay india, though. Which is probably a good thing.

Comment 7

[Ankit Patel]

(In reply to comment #6)
> Created an attachment (id=320890) [details]
> eBay India plugin as discussed
> 
> I copied over the en-US ebay plugin and adjusted the urls from ebay.com to
> ebay.in, changed the encoding and the short name.
> 
> Tested locally with german umlauts, which roundtrip right. Küken are not up on
> ebay india, though. Which is probably a good thing.
> 

Pike,

So, do you want all of the indic languages to make the changes accordingly?

Comment 8

[Axel Hecht [:Pike]]

I'd actually create two patches, those shipping in fx3 and those not, as they go through different tree rules, and then land those for you as appriate. If the plugin is right for you.

Comment 9

[Ankit Patel]

(In reply to comment #8)
> I'd actually create two patches, those shipping in fx3 and those not, as they
> go through different tree rules, and then land those for you as appriate. If
> the plugin is right for you.
> 

Thanks, that would be better!

Comment 10

[Axel Hecht [:Pike]]

Attachment: migrate all plugins on trunk over to the agreed form

Here's a patch to what is in attachment 320890 [details] for those locales that currently have eBay India.

Taking this bug, as I'll just land these, too.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 322257 [details] [diff] [review]
migrate all plugins on trunk over to the agreed form

Giving this approval 1.9 for the locales already frozen for fx3.

This includes an [RC2?].

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 320890 [details]
eBay India plugin as discussed

Actually setting the review flags by ankit's comments on this.

Comment 13

[Axel Hecht [:Pike]]

Checked in, marking FIXED. Please cvs update your working copies to include this change, and resolve any potential merge conflicts.

Checking in bn-IN/browser/searchplugins/eBay-in.xml;
/l10n/l10n/bn-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.2; previous revision: 1.1
done
Checking in gu-IN/browser/searchplugins/eBay-in.xml;
/l10n/l10n/gu-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.3; previous revision: 1.2
done
Checking in hi-IN/browser/searchplugins/eBay-in.xml;
/l10n/l10n/hi-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.2; previous revision: 1.1
done
Checking in ml/browser/searchplugins/eBay-in.xml;
/l10n/l10n/ml/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.2; previous revision: 1.1
done
Checking in pa-IN/browser/searchplugins/eBay-in.xml;
/l10n/l10n/pa-IN/browser/searchplugins/eBay-in.xml,v  <--  eBay-in.xml
new revision: 1.3; previous revision: 1.2
done

Comment 14

[Axel Hecht [:Pike]]

updated reference to http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/9debbf460918/reference/HEAD/gu-IN/ and http://hg.mozilla.org/users/axel_mozilla.com/l10n-src-verification/index.cgi/file/9debbf460918/reference/HEAD/pa-IN/