430729 - New Tab & New Window Icons Shift Position on Mouseover

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Louis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042407 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042407 Minefield/3.0pre

After this last icon change on Windows XP (I believe from this bug:)

https://bugzilla.mozilla.org/show_bug.cgi?id=429689

The new tab and new window button icons shift position on Mouseover. Large icons shift to the right and small icons shift to the right and down.



Reproducible: Always

Steps to Reproduce:
1. Mouseover New Tab or New Window Toolbar Icon
Actual Results:  
Icon shifts on Mouseover.

Expected Results:  
Icon shouldn't move.

This is using default Windows XP theme.

Comment 1

[dickvl]

Confirmed.
I've checked the icons (Toolbar-small.png) and the small printer icon is also affected: 1px to the right and 1px to the right.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042407 Minefield/3.0pre

Comment 2

[dickvl]

That should be; 1px to the right and 1px down.

Comment 3

[Bryan]

I'm seeing odd results when hovering over the toolbar icons while in classic mode on XP and small icons enabled. The new tab icon moves down and to the right (1px respectively) when hovered over but the printer icon simply moves down (1px) when hovered over. Neither the home, refresh or stop do anything when hovered over. 
With large icons enabled, only the new tab button moves down and to the right! 

~B

Comment 4

[(mostly gone) XtC4UaLL [:xtc4uall]]

this should get fixed before RC state

Comment 5

[Bryan]

It appears the "Home" icon is two px smaller then all other icons.  Also, it's
not centered on mouseover, it needs to move over 1px to the left.

~B

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

I see the problems with new tab, new window and print, but I am not seeing what you mean with home shifting, it should be staying in the same position.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Changes to new tab, new window and print are now fixed and will be updated in
the next windows icon drop.

Comment 8

[Bryan]

(In reply to comment #6)
> I see the problems with new tab, new window and print, but I am not seeing what
> you mean with home shifting, it should be staying in the same position.

Alex, the home button isn't moving. It appears to be 2px smaller (in height) then the other toolbar icons and it's not centered in the mouseover state, it's 1 px to the right in the mouseover state.

Question, why do only three of the icons shift on mouse over?  It makes it feel like the others are broken and seems inconsistent.  We have numerous inconsistencies here:

1) A few of the main toolbar buttons shift on mouseover; a few don't
2) Error console icons shift only when clicked on and not on mouseover

What is the thinking behind that?

~B 

Comment 9

[(mostly gone) XtC4UaLL [:xtc4uall]]

Alex, could you provide/name a Bug# for tracking the next icon drop, please?
maybe you also can add that bug on this bug's dependency and add a note to the whiteboard :-)

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

There isn't any rationale behind the icons shifting, some of then just happened to be misaligned when we got the alternate states.

I usually file the bug for checking in the icons as soon as the drop is ready, looks like it will be sometime late tomorrow.  I'll resolve this bug once they land.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

This will be fixed by bug 430759

Comment 12

[(mostly gone) XtC4UaLL [:xtc4uall]]

indeed it is.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050206 Minefield/3.0pre ID:2008050206