430908 - Land new windows toolbar icons (2008-04-28)

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug will track landing what will hopefully be the final drop of windows icons before RC1.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

These icons should be ready this evening.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Or perhaps this morning! :)

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, emphasize on "should be" we have all of the files, I am working on preparing the drop now.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

This is blocking since it fixes a blocker in that the back/forward dropmarker is always showing as enabled.

Alex: can we get those images checked in immediately and then we can remove this from the blocker list? Unless there are other changes coming in this drop that you believe should block us. I don't really know if I have a full understanding of what this is changing.

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: New Toolbar files

Landing these 4 files will clear the blocking flag, but we should leave the bug open for the full drop.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318317 [details]
New Toolbar files

r+uir+a=beltzner

Comment 7

[Reed Loden [:reed]]

Comment on attachment 318317 [details]
New Toolbar files


Checking in browser/themes/winstripe/browser/Toolbar-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v  <--  Toolbar-aero.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v  <--  Toolbar-small-aero.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.13; previous revision: 1.12
done
Checking in browser/themes/winstripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar.png,v  <--  Toolbar.png
new revision: 1.14; previous revision: 1.13
done

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #5)
> Landing these 4 files will clear the blocking flag, but we should leave the bug
> open for the full drop.

Filed 431285 for the remainder.

Comment 9

[Ed Lee :Mardak]

rtl xp small icons were shifted 1px left

xp small
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-small.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small.png

(open both in tabs and switch between the two)

And if you wanted to just double check the rest..

aero small
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-small-aero.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png

xp
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar.png

aero
4-25: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/87893472b320/browser/themes/winstripe/browser/Toolbar-aero.png
4-28: http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-aero.png

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: New Toolbar-small.png

A the disabled keyhole state was 1 pixel off in the last set of attachments, please land this update immediately.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Reopening to land updated file.

Comment 12

[Reed Loden [:reed]]

Comment on attachment 318330 [details]
New Toolbar-small.png

Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.14; previous revision: 1.13
done

Comment 13

[Ed Lee :Mardak]

Hrmm... comparing xp and vista small icons:

http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png

aero's disabled forwards seems to shift left compared to xp

Comment 14

[Ed Lee :Mardak]

Sorry, should be 

http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small.png
http://hg.mozilla.org/cvs-trunk-mirror/index.cgi/raw-file/878eb6749f48/browser/themes/winstripe/browser/Toolbar-small-aero.png

Comment 15

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Toolbar-small-aero.png

Corrected an off by one pixel error with the disabled 16x16 forward button

Comment 16

[Reed Loden [:reed]]

Comment on attachment 318335 [details]
Toolbar-small-aero.png

Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v  <--  Toolbar-small-aero.png
new revision: 1.6; previous revision: 1.5
done