Closed Bug 430908 Opened 12 years ago Closed 12 years ago

Land new windows toolbar icons (2008-04-28)

Categories

(Firefox :: Theme, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3

People

(Reporter: faaborg, Assigned: faaborg)

References

Details

Attachments

(3 files)

This bug will track landing what will hopefully be the final drop of windows icons before RC1.
Flags: blocking-firefox3?
These icons should be ready this evening.
Summary: Land new windows icons (2008-04-26) → Land new windows icons (2008-04-27)
Or perhaps this morning! :)
Flags: blocking-firefox3? → blocking-firefox3+
Summary: Land new windows icons (2008-04-27) → Land new windows icons (2008-04-28)
Yeah, emphasize on "should be" we have all of the files, I am working on preparing the drop now.
Status: NEW → ASSIGNED
Assignee: nobody → faaborg
Status: ASSIGNED → NEW
Blocks: 431120
This is blocking since it fixes a blocker in that the back/forward dropmarker is always showing as enabled.

Alex: can we get those images checked in immediately and then we can remove this from the blocker list? Unless there are other changes coming in this drop that you believe should block us. I don't really know if I have a full understanding of what this is changing.
Attached file New Toolbar files
Landing these 4 files will clear the blocking flag, but we should leave the bug open for the full drop.
Attachment #318317 - Flags: approval1.9?
Comment on attachment 318317 [details]
New Toolbar files

r+uir+a=beltzner
Attachment #318317 - Flags: ui-review+
Attachment #318317 - Flags: review+
Attachment #318317 - Flags: approval1.9?
Attachment #318317 - Flags: approval1.9+
Comment on attachment 318317 [details]
New Toolbar files


Checking in browser/themes/winstripe/browser/Toolbar-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-aero.png,v  <--  Toolbar-aero.png
new revision: 1.8; previous revision: 1.7
done
Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v  <--  Toolbar-small-aero.png
new revision: 1.5; previous revision: 1.4
done
Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.13; previous revision: 1.12
done
Checking in browser/themes/winstripe/browser/Toolbar.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar.png,v  <--  Toolbar.png
new revision: 1.14; previous revision: 1.13
done
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: Land new windows icons (2008-04-28) → Land new windows toolbar icons (2008-04-28)
Target Milestone: Firefox 3 → ---
(In reply to comment #5)
> Landing these 4 files will clear the blocking flag, but we should leave the bug
> open for the full drop.

Filed 431285 for the remainder.
Attached image New Toolbar-small.png
A the disabled keyhole state was 1 pixel off in the last set of attachments, please land this update immediately.
Reopening to land updated file.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 318330 [details]
New Toolbar-small.png

Checking in browser/themes/winstripe/browser/Toolbar-small.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small.png,v  <--  Toolbar-small.png
new revision: 1.14; previous revision: 1.13
done
Attached image Toolbar-small-aero.png
Corrected an off by one pixel error with the disabled 16x16 forward button
Comment on attachment 318335 [details]
Toolbar-small-aero.png

Checking in browser/themes/winstripe/browser/Toolbar-small-aero.png;
/cvsroot/mozilla/browser/themes/winstripe/browser/Toolbar-small-aero.png,v  <--  Toolbar-small-aero.png
new revision: 1.6; previous revision: 1.5
done
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.