Closed Bug 431052 Opened 12 years ago Closed 12 years ago

Please remove execute permissions from some Bugzilla files

Categories

(mozilla.org :: CVS: Administration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ddkilzer, Assigned: justdave)

Details

The following files in the Bugzilla CVS repository should not have execute permissions (they are all 0755 but should be 0644):

Bugzilla/Bug.pm
skins/standard/global/body-back.gif 
skins/standard/global/header.png
skins/standard/index/front.png
template/en/default/admin/keywords/confirm-delete.html.tmpl
template/en/default/admin/keywords/create.html.tmpl
template/en/default/admin/keywords/created.html.tmpl
template/en/default/admin/keywords/edit.html.tmpl
template/en/default/admin/keywords/list.html.tmpl
template/en/default/admin/keywords/rebuild-cache.html.tmpl

The execute bits should be removed from these files in the CVS repository.
WFM on both 3.0.4 and 3.1.4. They are all set to 640.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
(In reply to comment #1)
> WFM on both 3.0.4 and 3.1.4. They are all set to 640.

I'm guessing they're fixed by checksetup.pl, but they're still wrong in the CVS repository.

STEPS TO REPRODUCE
1. Check out a fresh copy of bugzilla tip-of-tree:

$ CVSROOT=':pserver:anonymous@cvs-mirror.mozilla.org:/cvsroot' cvs co -d bugzilla mozilla/webtools/bugzilla

2. Look at permissions of the files from Comment #0, for example:

$ ls -la bugzilla/Bugzilla/Bug.pm 
-rwxr-xr-x   1 ddkilzer  ddkilzer  122676 Apr 10 09:33 bugzilla/Bugzilla/Bug.pm

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Furthermore, the distribution of Bugzilla 3.0.3 has these permissions wrong as well (before running checksetup.pl):

1. Download the bugzilla-3.0.3.tar.gz.

$ wget -c http://ftp.mozilla.org/pub/mozilla.org/webtools/bugzilla-3.0.3.tar.gz

2. Extract the archive.

$ tar xzf bugzilla-3.0.3.tar.gz

3. Look at the permissions of the files from Comment #0, for example:

$ ls -la bugzilla-3.0.3/Bugzilla/Bug.pm 
-rwxr-xr-x  1 ddkilzer  admin  75775 Oct 17  2007 bugzilla-3.0.3/Bugzilla/Bug.pm
That's the goal of checksetup.pl, to set permissions right. What their permissions are before running checksetup.pl doesn't matter.
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → INVALID
these sorts of things trigger stupid red flags, it's easy enough to fix them.
Status: RESOLVED → REOPENED
Component: Bugzilla-General → CVS: Administration
Product: Bugzilla → mozilla.org
Resolution: INVALID → ---
Version: 3.0.3 → other
Assignee: general → server-ops
Status: REOPENED → NEW
QA Contact: default-qa → justin
Summary: Incorrect execute permissions on files in CVS repository → Please remove execute permissions from some Bugzilla files
Thanks for moving this to the correct component!

Assignee: server-ops → justdave
Done.

The following files were actually found in the Attic:

template/en/default/admin/keywords/created.html.tmpl
template/en/default/admin/keywords/rebuild-cache.html.tmpl
Status: NEW → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.