431091 - Crash when deleting multiple items from the History sidebar [@ mozStorageTransaction::~mozStorageTransaction]

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Simon Bünzli]

Steps to Reproduce:
1. Get yourself several similar URLs of history
2. ???
3. Search for those URLs in the sidebar and delete them there

Unfortunately, this isn't 100% reproducible (hence the missing step 2).

As per the crash reports (see URL), this is a regression from between April 22 and April 23.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I think you meant for this to be in Firefox::Places.

We need better STR here before we can consider blocking. 

Comment 2

[Steve England [:stevee]]

I got this today, but again is not reproducible on demand. But I had my normal profile open (90 day history), History > Show All History, typed a term into the Search bar (10s of results returned), gave focus to results area, CTRL+A to select all the results, pressed Delete to remove results, and crash!

Signature	mozStorageTransaction::~mozStorageTransaction()
UUID	0b4ab366-160f-11dd-b862-001cc45a2c28
Time	2008-04-29 10:08:35-07:00
Uptime	2755
Product	Firefox
Version	3.0pre
Build ID	2008042906
OS	Windows NT
OS Version	5.1.2600 Service Pack 2
CPU	x86
CPU Info	AuthenticAMD family 6 model 8 stepping 1
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x3a000039
Comments	opened history in places, searched for a term, CTRL+A to select all, hit DEL to delete them, crash
Frame  	Module  	Signature [Expand]  	Source
0 	xul.dll 	mozStorageTransaction::~mozStorageTransaction 	mozStorageHelper.h:81
1 	xul.dll 	mozStorageTransaction::`scalar deleting destructor' 	
2 	xul.dll 	nsDownloadManager::OnEndUpdateBatch 	mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:1807
3 	xul.dll 	nsNavHistory::EndUpdateBatch 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3576
4 	xul.dll 	nsNavHistory::RemovePages 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3775
5 	xul.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
6 	xul.dll 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2369


Signature	nsCOMPtr_base::~nsCOMPtr_base()
UUID	5d53b3cc-1611-11dd-aba9-001cc45a2ce4
Time	2008-04-29 10:25:53-07:00
Uptime	116
Product	Firefox
Version	3.0pre
Build ID	2008042906
OS	Windows NT
OS Version	5.1.2600 Service Pack 2
CPU	x86
CPU Info	AuthenticAMD family 6 model 8 stepping 1
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x182
Comments	
Frame  	Module  	Signature [Expand]  	Source
0 	xul.dll 	nsCOMPtr_base::~nsCOMPtr_base 	nsCOMPtr.cpp:81
1 	xul.dll 	mozStorageTransaction::`scalar deleting destructor' 	
2 	xul.dll 	nsDownloadManager::OnEndUpdateBatch 	mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp:1807
3 	xul.dll 	nsNavHistory::EndUpdateBatch 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3576
4 	xul.dll 	nsNavHistory::RemovePages 	mozilla/toolkit/components/places/src/nsNavHistory.cpp:3775
5 	xul.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
6 	xul.dll 	XPCWrappedNative::CallMethod 	mozilla/js/src/xpconnect/src/xpcwrappednative.cpp:2369

From bugzilla URL, no crashes in the 20080422 build, crashes in the 20080423 build.
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-04-22-07-trunk/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2008-04-23-05-trunk/

Checkins to module PhoenixTinderbox between 2008-04-21 23:00 and 2008-04-22 23:00 : 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-22-06&maxdate=2008-04-23-06&cvsroot=%2Fcvsroot

Comment 3

[Steve England [:stevee]]

Er, range should have been

Checkins to module PhoenixTinderbox between 2008-04-22 06:00 and 2008-04-23 06:00 : 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-04-22+06&maxdate=2008-04-23+06&cvsroot=%2Fcvsroot

Comment 4

[Ed Lee :Mardak]

Dupe of bug 431597 which was fixed by bug 431346.

Comment 5

[Ed Lee :Mardak]

Er. well.. I suppose this says history sidebar.