431332 - drag & drop in places menupopups force a copy op instead of moving

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

Comment 1

[Marco Bonardo [:mak]]

updating summary and asking blocking
this happens in all menupopups IIRC

Comment 2

[Alice0775 White]

I make a small patch for this Bug. It seems to work well.
However, I have few knowledge about Places.  Therefore, there may be another problem to this patch.


chrome\browser.jar\content\browser\places\controller.js
  onDrop: function PCDH_onDrop(insertionPoint) {


      else {
-        if (unwrapped.id && !this.canMoveContainer(unwrapped.id, null))
-          copy = true;
-        else if (unwrapped.concreteId &&
-                 !this.canMoveContainer(unwrapped.concreteId, null))
-          copy = true;

        transactions.push(PlacesUIUtils.makeTransaction(unwrapped,
                          flavor.value, insertionPoint.itemId,
                          index, copy));


      else {
+        if (unwrapped.id && !this.canMoveContainer(unwrapped.id, null)){
+          copy = true;
+        }else{
+            if (unwrapped.concreteId &&
+                 !this.canMoveContainer(unwrapped.concreteId, null)){
+              copy = true;
+            }else{
+              copy= false;
+            }
+        }


        transactions.push(PlacesUIUtils.makeTransaction(unwrapped,
                          flavor.value, insertionPoint.itemId,
                          index, copy));

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch

i feel like this check is wrong (canMove, so copy)

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 318574 [details] [diff] [review]
patch

r=me

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 318574 [details] [diff] [review]
patch

a1.9=beltzner

Comment 7

[Dietrich Ayala (:dietrich)]

Checking in browser/components/places/content/menu.xml;
/cvsroot/mozilla/browser/components/places/content/menu.xml,v  <--  menu.xml
new revision: 1.132; previous revision: 1.131
done

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

Verified fixed for me using Vista HP SP1 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008043010 Minefield/3.0pre Firefox/3.0 ID:2008043010

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050206 Minefield/3.0pre ID:2008050206

Comment 10

[Aakash Desai [:aakashd]]

Litmus test cases were updated for regression testing on 3.0 and 3.1 test runs.

For 3.0,
https://litmus.mozilla.org/show_test.cgi?id=7535

Fro 3.1,
https://litmus.mozilla.org/show_test.cgi?id=7457

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv