431383 - Replace GIF with APNG throbber

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Martin Schröder [:mschroeder]]

On trunk there exists now a APNG throbber for all themes (also in toolkit). We still use the old animated GIFs (see URL field).

Comment 1

[Martin Schröder [:mschroeder]]

Code:
-  list-style-image: url("chrome://global/skin/throbber/Throbber-small.gif");
+  list-style-image: url("chrome://global/skin/icons/loading_16.png");

We also have a own copies of the throbber for Sunbird (Throbber.png and Throbber.gif), but I don't know why. ;)

Comment 2

[Martin Schröder [:mschroeder]]

Four references left:
/calendar/base/themes/winstripe/calendar-subscriptions-dialog.css
    * line 79 -- list-style-image: url("chrome://global/skin/throbber/Throbber-small.png");
    * line 83 -- list-style-image: url("chrome://global/skin/throbber/Throbber-small.gif");

/calendar/base/themes/pinstripe/calendar-subscriptions-dialog.css
    * line 79 -- list-style-image: url("chrome://global/skin/throbber/Throbber-small.png");
    * line 83 -- list-style-image: url("chrome://global/skin/throbber/Throbber-small.gif");

Comment 3

[Stefan Sitter [:ssitter]]

See also Bug 428761 about the similar (or same ?) issue.

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Comment 6

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

Comment 7

[Stefan Sitter [:ssitter]]

Comment on attachment 345189 [details] [diff] [review]
Patch v2

r=ssitter

(I noticed an issue with the throbber image not being displayed if the throbber is moved from toolbar back to customize toolbar dialog. I reproduced this in a nightly build therefore it's not related to this patch.)

Comment 8

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/34d90ab5a741>

-> FIXED

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".