431528 - Rename a tag does not delete the old one but is adding a new tag instead

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042906 Minefield/3.0pre ID:2008042906

If you have a bookmark where a tag is set and you rename this tag, the old name is not removed and the bookmark is tagged with both values.

Steps to reproduce:
1. Bookmark a page with Ctrl+D or via star
2. Give the bookmark a tag e.g. "Test"
3. Open the Library and select the bookmark
4. Change the tag to "Test1" within the details pane
5. Click tab so the list gets updated
=> Now the bookmark is tagged with "Test" and "Test1"

When a tag is renamed the old one should be removed from places. It looks like that it is copied at the moment. If you delete the old tag afterwards it does work. But trying to rename the old tag again does make always a copy of the tag.

Dietrich or Marco, does it happen due to the same issue like bug 431332?

Comment 1

[Marco Bonardo [:mak]]

(In reply to comment #0) 
> Dietrich or Marco, does it happen due to the same issue like bug 431332?

unlikely :(

Comment 2

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #0)
> 5. Click tab so the list gets updated

I don't know what you mean. I tried clicking in the right half of the Library window and I could reproduce the problem. I saw it also jump about 5 times, while I saw flashes of the contents of the bookmarks toolbar folder. When I tried the same in a new profile I couldn't reproduce it anymore.

Comment 3

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #2)
> I saw it also jump about 5 times,
"it" was the bottom pane, which changed size after every jump. I guess that Library got wild for a few seconds and wanted to display several folders at the same time. But the problem is gone :/.

Comment 4

[Ria Klaassen (not reading all bugmail)]

OK, I can reproduce it now. I need to select the "Tags" folder in the left pane. Also the "Recent Tags" folder triggers this bug, and the latter causes also the jumps. And I think now it is only one flashing folder, not multiple folders like I said earlier. 
Regression window is 
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1209124020&maxdate=1209145199
Bug 430213 is the only places bug in that range.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Marco, do you know what in the patch for bug 430213 is causing this? I'm beginning to question my blocking decision for that fix, and wonder if we shouldn't just back it out.

Comment 6

[Marco Bonardo [:mak]]

probably the fastest solution would be back out the left pane editing in the pane and put back properties in that view to rename... will still check tomorrow if i can find a better way...

Comment 7

[Marco Bonardo [:mak]]

the patch in bug 431140 is solving this, so let's see if we can take it

Comment 8

[Dietrich Ayala (:dietrich)]

was this fixed by checkin of bug 431140?

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Yes, it was. Should show up in tomorrow's nightly.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre

Comment 11

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=5878 added to Litmus.

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv