431853 - Tweak/Clean Site Identity Button + URL bar on OS X

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Stephen Horlander [:shorlander]]

Some tweaks and cleanup for the site button and urlbar.

- Adding glow for favicons like in bug 430767
- Adding pressed states to DV and EV states
- Misc. cleanup for minor visual glitches. bug 414732 and 419932

Comment 1

[Stephen Horlander [:shorlander]]

Attachment: Favicon Glow

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: Pressed States

Comment 3

[Stephen Horlander [:shorlander]]

Attachment: Identity button and URL bar patch

I moved some stuff around and took out some !important(s) because I didn't see where they were needed.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 319014 [details] [diff] [review]
Identity button and URL bar patch

>Index: browser/themes/pinstripe/browser/browser.css

>+#identity-box.unknownIdentity > hbox > #identity-icon-label {
>+  display: none;

Is this really needed? Shouldn't be taking up any space in that case since the label's value is empty.

>+/* - Focus state */

>+#urlbar[focused="true"] > #identity-box > hbox > #identity-icon-label {
>+  background-image: url("chrome://browser/skin/urlbar/startcap-secure-end-focused.png");

Missing a ".verifiedDomain" here I think.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Shouldn't this block the release, so there is the same look under the different OS, especially for the DV and EV states?

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to comment #4)
> >+#identity-box.unknownIdentity > hbox > #identity-icon-label {
> >+  display: none;
> 
> Is this really needed? Shouldn't be taking up any space in that case since the
> label's value is empty.

It actually has a default padding for use with the EV and DV states. So if we don't hide it will have to be handled in another way.

> Missing a ".verifiedDomain" here I think.
> 
Thanks!

Comment 7

[Dão Gottwald [:dao]]

Interesting, so :active works for plain boxes. Do we want that for Windows as well?

Comment 8

[Stephen Horlander [:shorlander]]

Attachment: Identity button and URL bar patch v2

Modified with one fix listed above.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #7)
> Interesting, so :active works for plain boxes. Do we want that for Windows as
> well?

I filed bug 431983 for that.

Comment 10

[Chris Blore]

Sorry about accidentally reassigning to the default assignee. Having a bit of difficulty with my mouse at the moment!

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319088 [details] [diff] [review]
Identity button and URL bar patch v2

a=beltzner for this patch and associated images; doesn't block, but nice polish.

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 319088 [details] [diff] [review]
Identity button and URL bar patch v2

>-#identity-box:active,
>+#identity-box:hover:active,
> #identity-box[open="true"] {
>   background-image: url("chrome://browser/skin/urlbar/startcap-active.png");
> }

#identity-box[open="true"] doesn't work, does it?

Comment 13

[Reed Loden [:reed]]

Is this ready to be checked-in?

Comment 14

[Stephen Horlander [:shorlander]]

(In reply to comment #13)
> Is this ready to be checked-in?
> 

Sorry, forgot to update this.

Checked in on 2008-05-05

mozilla/browser/themes/pinstripe/browser/browser.css 	1.154
mozilla/browser/themes/pinstripe/browser/jar.mn 	1.88
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-active-rtl.png 	1.2
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-active.png 	1.3
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end-focused.png 	1.2
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end.png 	1.3
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid-focused.png 	1.2
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid.png 	1.3
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start-focused.png 	1.2
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start.png 	1.3
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-focused.png 	1.2
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end.png 	1.3
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-end-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-mid-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-secure-start-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-end-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-mid-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/startcap-verified-start-active.png 	1.1
mozilla/browser/themes/pinstripe/browser/urlbar/urlbar-favicon-glow.png 	1.1 

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008051304 Minefield/3.0pre ID:2008051304