431983 - style :active states for the identity button, location dropdown button and search engine button on Windows

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons-aero.png

Note that the DV and EV gradients are extracted from the original siteButtons.png.

Comment 1

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons.png

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

Comment 3

[Dão Gottwald [:dao]]

Attachment: screenshot: normal active states

This gradient is created from scratch and identical for XP and Vista.

Comment 4

[Kai Liu]

Dao, I just posted bug 431999.  It's very trivial, so do you want to incorporate that into this patch, or would you prefer that I post a separate patch for that?

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> Dao, I just posted bug 431999.  It's very trivial, so do you want to
> incorporate that into this patch, or would you prefer that I post a separate
> patch for that?

I'd prefer a separate patch, since it's not directly related and touches different style rules.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319124 [details]
navbar-textbox-buttons-aero.png

Dao: I think Alex has better insight into the requirements for the gradients; can you sync up with him on this? He's the one who should approve.

Comment 7

[Dão Gottwald [:dao]]

Alex: ping?

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 319127 [details]
screenshot: normal active states

These seem to depress farther into the browser than other buttons, like back or forward.

Comment 9

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons-aero.png

Comment 10

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons.png

Comment 11

[Dão Gottwald [:dao]]

Attachment: screenshot

Comment 12

[Dão Gottwald [:dao]]

Alex: ping?

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: types of depressed states

Sorry about the lag.  What I am worried about is that between the navigation buttons, the stop/reload/home controls, and the site button, we will end up with three different appearances for depressed states. Or four types of depressed states if you count dialog box buttons as well.

I think we need to either:

1) match the depressed states of the navigation controls perfectly (probably have the iconfactory create new files that both match and work well with alternate themes).  I think we might want to switch to using the same background for the button as the text field it is attached to, so create a button that is almost entirely transparent except for a center reflection line and lower shadow (or upper shadow if the button is depressed).

or, a second option that might be impossible to implement:

2) leverage the native depressed appearance for buttons.  This still gives us three types of depressed states in the toolbar (so personally I tend to lean more towards option 1), however the appearance of the button would at least be very consistent with other buttons in the OS theme.

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 321566 [details]
screenshot

see comment #13 for a few different approaches I think we should try

Comment 15

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons.png

Comment 16

[Dão Gottwald [:dao]]

Attachment: navbar-textbox-buttons-aero.png

Comment 17

[Dão Gottwald [:dao]]

Attachment: screenshot

Comment 18

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Source file for small navigation icons

This file includes all of the layer effects to create the hover and depressed states on Vista and XP.  Let's copy these effects exactly for each platform, and attach the photoshop file for me to ui-review.

Comment 19

[Dão Gottwald [:dao]]

Attachment: screenshot with 'Hit' layer from psd

Comment 20

[Dão Gottwald [:dao]]

Attachment 324376 [details] looks way too dark to me. Not sure why it works for the keyhole, but it doesn't seem to work here. I think we should go with attachment 324365 [details] for now. Once the code is there, you could ask the iconfactory to replace the image with something better.

Comment 21

[Alex Faaborg [:faaborg] (Firefox UX)]

We could match the inner shadow but scale back the color overlay.  I agree that it looks way too dark.  Primarily, I want the buttons to feel like they have the same curvature and depth, which is basically all about the drop shadow, and varies for Vista and XP.

Comment 24

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 324365 [details]
screenshot

Removing the request for ui-review since we have Sean working on some new artwork for our windows themes.

Comment 25

[Alex Faaborg [:faaborg] (Firefox UX)]

uiwanted: post images

Comment 26

[Dão Gottwald [:dao]]

(In reply to comment #25)
> uiwanted: post images

Note the 'icon' keyword.

Comment 27

[Alex Faaborg [:faaborg] (Firefox UX)]

this depends on bug 462977, since we might end up fixing everything over there
with one patch.

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks fine for for all dropdowns. Verified fixed on trunk and 1.9.1 on XP and Vista.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090519 Minefield/3.6a1pre (.NET CLR 3.5.30729)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090520 Shiretoko/3.5b5pre (.NET CLR 3.5.30729)

Comment 29

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

two different buttons in the main window