431889 - Implement breadcrumbs for administration pages

Status: NEW

(Bugzilla :: User Interface, enhancement, P3)

Description

[Tiago Mello [:timello]]

It would be nice to have that usability help on Bugzilla mainly for administrators. The breadcrumbs will indicate which page the admin is editing...

Ex.:

"Administration > Products > Products of classification xyz > YourProductHere > Components"

Comment 1

[Marc Schumann [:Wurblzap]]

Yeah, great!

A couple of thoughts...
- We should get rid of what the links we put at the bottom of some
  administrative pages (template/en/default/admin/components/footer.html.tmpl
  and friends); breadcrumbs should replace this.
- We should have a breadcrumbs.html.tmpl template instead of placing
  breadcrumbs on each administrative page individually.
- The breadcrumbs template should live in template/en/default/global/ so that,
  in follow-up bugs, we can expand breadcrumbs to other pages more easily
  (think “Search > Bug List > Bug 12345” or “New Bug > YourClassification >
  YourProduct”).

Comment 2

[Guy Pyrzak]

Ironically I was just having a conversation about the lack usability for the admin pages. This will unfortunately have to go into the queue behind the home page fixes (I'm sure you can see why). I will be tracking this bug. Thanks for the feedback and keep an eye on this bug. I promise it'll get in there along with a lot of other usability improvements for the admin pages.

Comment 3

[Tatiane]

Attachment: Patch to introduce Breadcrumbs in the administrative pages

Comment 4

[Tatiane]

Attachment: Patch to introduce Breadcrumbs in the administrative pages

Comment 5

[Marc Schumann [:Wurblzap]]

Comment on attachment 320570 [details] [diff] [review]
Patch to introduce Breadcrumbs in the administrative pages

I'd like to review your patch. I get “patching file template/en/default/admin/admin.html.tmpl
patch: **** malformed patch at line 17: Index: template/en/default/admin/classifications/add.html.tmpl” when trying to apply your patch, though. Can you please attach a fresh patch, using “cvs -q diff -uNp”?

Comment 6

[Tatiane]

Ill fix the patch and send a new one soon. Thanks.

Comment 7

[Tatiane]

Attachment: Patch to add breadcrumbs

Comment 8

[Frédéric Buclin]

wurblzap: still alive?

Comment 9

[Marc Schumann [:Wurblzap]]

I'd love to see this feature. I'm busy irl, though, and translating 3.2.4 and 3.4rc1 is on my bz list further up than this one here.

I'll get to it in time, but not really soon.

Comment 10

[Frédéric Buclin]

Comment on attachment 346241 [details] [diff] [review]
Patch to add breadcrumbs

The patch unfortunately no longer applies due to conflicts with other checkins.

Rather than editing each template, is there no way to do it in a central way, e.g. in global/header.html.tmpl (maybe by parsing the path to the template)?



>Index: template/en/default/admin/admin.html.tmpl

> [% PROCESS global/header.html.tmpl title = title
>+ 				   title = "Administration"

You are redefining the title of the template.



>Index: template/en/default/global/bread_crumbs.html.tmpl

>+  # The Initial Developer of the Original Code is Netscape
>+  # Communications
>+  # Corporation. Portions created by Netscape are
>+  # Copyright C 1998 Netscape Communications Corporation. All
>+  # Rights Reserved.

The initial developer is not Netscape. See http://www.mozilla.org/MPL/boilerplate-1.1/mpl-sh for the correct license template.


>+[% bread_crumbs_structure = {

Data in this hash seems redundant to me, compared to what we already know from other templates.



>Index: template/en/default/global/header.html.tmpl

>+    <script type="text/javascript" language="JavaScript" src="localconfig.js"></script>
>+    <script type="text/javascript" language="JavaScript" src="quicksearch.js"></script>

Why are those two JS files required? And what are they?


>+    <link href="css/menu.css" rel="stylesheet" type="text/css">

menu.css doesn't exist (and the path is now skins/standard/ instead of css/).


>Index: template/en/default/global/menu.html.tmpl

>+  # The Initial Developer of the Original Code is Netscape Communications

Same comment as above.


>+  [% menu_items.push({

Why is there additional stuff here?


This is a super-quick review. I didn't look at all details of the patch.