432355 - Color border of site button to match gradients for SSL and EV states

Status: VERIFIED INVALID

(Firefox :: Theme, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

in https://bugzilla.mozilla.org/show_bug.cgi?id=417844#c104 Matt Cosentino writes:
"There was a lot of talk about using the colored border of the gradients but I
didn't see anyone that actually did it.  Here is how it looks on XP.  These are
screenshots from a working implementation that includes hover and active
states(not shown)."

https://bugzilla.mozilla.org/attachment.cgi?id=319056

I think this really helps aesthetically, with making the control look like a button, and with mirroring the appearance of the forward button for internal consistency in the theme.  Requesting blocking to pick up wanted.  Matt: can you post a patch?

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

If we go for this approach we should bring back the lighter lines at the top and bottom of the gradient since they were removed to work better with the gray native color of text field borders.

Comment 2

[scratch]

could somebody post the css for this?  i'm curious as to how it's possible.

Comment 3

[Matt Cosentino]

I'm working on the patch, I'll try to post something later today.

Comment 4

[Matt Cosentino]

Attachment: patch

Comment 5

[Matt Cosentino]

Attachment: navbar-textbox-buttons-aero.png

Comment 6

[Matt Cosentino]

Attachment: navbar-textbox-buttons.png

Comment 7

[Matt Cosentino]

Hopefully I did that right. :)

I tested this in both Vista and XP, in both default and classic themes.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 319971 [details] [diff] [review]
patch

Dao, is it a part you can review?

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 319971 [details] [diff] [review]
patch

this needs ui-review

Comment 10

[Dão Gottwald [:dao]]

Note that the given patch styles the identity button's depressed state inconsistently. I added bug 431983 as a dependency therefore.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 319971 [details] [diff] [review]
patch

ui-r=beltzner, definitely

This ui-r is also for the revised gradients as per comment 1

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Matt, could you come up with a new patch which includes the parts mentioned in comment 1?

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

I recommend we use full images like the OS X theme and wontfix this, but still setting the polish keywords/whiteboard terms to track.

Comment 14

[Matt Cosentino]

Alex, I absolutely agree with you.  As close as I was able to get with just using the rounded borders, it just isn't quite good enough.

Comment 15

[Matt Cosentino]

Aha!  Which is now easily doable with 3.1's addition of -moz-border-image. :)

I'll get this patched up.

Comment 16

[Alex Faaborg [:faaborg] (Firefox UX)]

filed follow up bug 462977 for using -moz-border-image for the site buttons.

Comment 17

[Shawn Wilsher :sdwilsh]

Matt - still interested in getting this bug fixed?  Once you get a patch posted, you should request review from [e-mail].  We'll need it soon if it is going to make 3.1

Comment 18

[Alex Faaborg [:faaborg] (Firefox UX)]

resolving as invalid in favor of bug 462977