Closed Bug 432029 Opened 16 years ago Closed 16 years ago

Accessibility fixes in mail/components/addressbook XUL files

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: MarcoZ, Assigned: MarcoZ)

References

Details

(Keywords: access)

Attachments

(1 file, 3 obsolete files)

Fixes to add missing label/control associations and aria-labelledby labelling where it makes sense (where one expression is made up of several controls).
Attached patch Patch (obsolete) — Splinter Review
Missing labels, and adding the title to the xul:page element in the contact panels Sidebar makes sure screen readers do not use the URL as the title for that grouping. With this, screen readers will speak "Contacts Sidebar" as the grouping title when tabbing into the sidebar.
Attachment #319189 - Flags: review?
Attachment #319189 - Flags: review? → review?(philringnalda)
Attachment #319189 - Attachment is obsolete: true
Attachment #320660 - Flags: review?(philringnalda)
Attachment #319189 - Flags: review?(philringnalda)
Comment on attachment 320660 [details] [diff] [review]
Reduce edits, otherwise identical.

I'm not sure quite what to do here, other than "not that." addressSidebar.label is the string for the menuitem in the View menu, and while it happens to be a better title for reading than addressesSidebarTitle.label in at least some of the languages I can puzzle out, that doesn't mean it's not an entirely incorrect string to use as a title in some other language that I can't guess at. Reusing a string in a different place, in a different context, where only localizers who use a screen reader will ever notice it, just isn't a good idea.

I'd also really like to avoid including around 250 extra strings in the sidebar, just to get at that one string, but I don't have any good ideas about how to avoid it just yet.
Attachment #320660 - Flags: review?(philringnalda) → review-
Attached patch Different approach (obsolete) — Splinter Review
Don't include messengercompose.dtd, instead add another entity to abContactsPanel.dtd with a comment explaining that this is used for accessibility only and that it should match the string that makes up the visual title, and which is in messengercompose.dtd.
Attachment #320660 - Attachment is obsolete: true
Attachment #320860 - Flags: review?(philringnalda)
Attached patch Third approachSplinter Review
Thanks to a pointer from Philor, this patch doesn't need any string bundle additions or changes at all.
Attachment #320860 - Attachment is obsolete: true
Attachment #320865 - Flags: review?(philringnalda)
Attachment #320860 - Flags: review?(philringnalda)
Blocks: 370391
Comment on attachment 320865 [details] [diff] [review]
Third approach

That looks like the one we want! r=philringnalda
Attachment #320865 - Flags: review?(philringnalda) → review+
Checking in mail/components/addrbook/content/abContactsPanel.js;
/cvsroot/mozilla/mail/components/addrbook/content/abContactsPanel.js,v  <--  abContactsPanel.js
new revision: 1.18; previous revision: 1.17
done
Checking in mail/components/addrbook/content/addressbook.xul;
/cvsroot/mozilla/mail/components/addrbook/content/addressbook.xul,v  <--  addressbook.xul
new revision: 1.78; previous revision: 1.77
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Verified fixed in Thunderbird version 3.0a2pre (2008051603)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: