432218 - Remove TB 1.5 specific code in getMailBar() function

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Simon Paquet [:sipaq]]

We don't support Tb 1.5, so we can do the following in the getMailBar() function:

 function getMailBar() {
   return document.getElementById("mail-bar2") ||
-         document.getElementById("mail-bar") ||
          document.getElementById("msgToolbar");
 }

Patch coming.

Comment 1

[Stefan Sitter [:ssitter]]

Does this obsoletes the existing Bug 402038? Or should it block it?

Comment 2

[Simon Paquet [:sipaq]]

As Philipp correctly points out in bug 402038 comment 9, this should be done in followup-bugs, of which this is one. Therefore I marked bug 402038 as FIXED.

Comment 3

[Bas van den Bosch]

It was agreed to no support TB1.5 but also to try to not break it. This seems like a minimal thing so why not let it be for now. Otoh there's not much users of TB1.5 anymore afaik.

Comment 4

[Simon Paquet [:sipaq]]

(In reply to comment #3)
> It was agreed to no support TB1.5 but also to try to not break it.

That was the decision during the 0.8 cycle. We're now in the 0.9 cycle and have already broken TB 1.5 in other places as well. I've also seen no effort at all anywhere to keep Lightning alive for Tb 1.5, so I believe there is no interest for this in the community.

Comment 5

[Simon Paquet [:sipaq]]

Attachment: Patch

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 319450 [details] [diff] [review]
Patch

r=philipp

Comment 7

[Simon Paquet [:sipaq]]

Patch checked into HEAD and MOZILLA_1_8_BRANCH

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to comment #3)
> It was agreed to no support TB1.5 but also to try to not break it.

I second Simon's opinion. I believe TB1.5 has been EOL'd some time ago.