Closed Bug 432417 Opened 12 years ago Closed 12 years ago

calRecurrenceInfo::onStartDateChange leaves wrong RECURRENCE-IDs

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Assigned: dbo)

Details

Attachments

(2 files, 1 obsolete file)

Attached file test ics file
spin-off bug from bug 368976

When adopting RECURRENCE-IDs of overridden items, those have to be tracked in timezone of the master's DTSTART timezone, otherwise they potentially don't match anymore.

To reproduce:
1. Subscribe to the attached test ics file.
2. Modify the whole series' to start e.g. 5 hours later.
=> in effect, the RECURRENCE-ID of the overridden item doesn't match anymore, you see two occurrences for 30th of march, the overridden one starting on 29th and a proxy starting on 30th.
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #319548 - Flags: review?(philipp)
Flags: in-testsuite?
Didn't you mention something about this not working for RDATEs?
Comment on attachment 319548 [details] [diff] [review]
fix

Yes, reading <http://tools.ietf.org/rfcmarkup?doc=draft-ietf-calsify-rfc2445bis-08#section-3.8.4.4> again, I think it's valid that RDATE instances could be overridden (RECURRENCE-ID == RDATE).
Attachment #319548 - Attachment is obsolete: true
Attachment #319548 - Flags: review?(philipp)
Flags: wanted-calendar0.9+
Flags: blocking-calendar0.9?
Flags: blocking-calendar0.9? → blocking-calendar0.9+
Attached patch fix - v2Splinter Review
this should do for RDATEs, too
Attachment #330541 - Flags: review?(philipp)
Comment on attachment 330541 [details] [diff] [review]
fix - v2


>+        for (var i in ritems) {
>+            var ritem = ritems[i];
Any reason not to use for each (var ritem in ritems) ?


r=philipp
Attachment #330541 - Flags: review?(philipp) → review+
No, there is not (I just took over most of the code); changed to use for-each loop.

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Checked in mxr.mozilla.org -> VERIFIED
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.