Remove browser_sanitize-download-history.js

RESOLVED FIXED in Firefox 37

Status

()

Firefox
General
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: Gavin, Assigned: Paolo)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 37
Points:
1
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See e.g. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1210055040.1210058195.22882.gz&fulltext=1

It's been failing intermittently since it was landed (bug 431729). Could be a timing issue, given that it uses a setTimeout. I've disabled it for now.
shouldn't be a timeout issue since it uses a setTimeout of zero so the load handlers fire
A setTimeout of 0 is a setTimeout of 10ms, and it can still introduce races if the machine is heavily bogged down (which is the case for the Linux unit test machines).
(Assignee)

Updated

3 years ago
Summary: browser_sanitize-download-history.js failing intermittently on Linux tinderbox → Remove browser_sanitize-download-history.js
(Assignee)

Comment 3

3 years ago
Created attachment 8540168 [details] [diff] [review]
The patch

This test has been disabled for quite some time, and it cannot be re-enabled because it uses nsIDownloadManager.

There is no point in having the file in the tree. Other existing tests, rather than one with an intermittent failure, are a better starting points if we ever want to write a front-end test for this functionality.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #8540168 - Flags: review?(mak77)
(Assignee)

Comment 4

3 years ago
This is part of the work to remove all references to nsIDownloadManager.
Blocks: 851471
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+

Updated

3 years ago
Iteration: --- → 37.2

Updated

3 years ago
Iteration: 37.2 → 37.3
Attachment #8540168 - Flags: review?(mak77) → review+
strange, I was sure to have marked this patch yesterday... somehow my changes were not submitted...
https://hg.mozilla.org/mozilla-central/rev/5ff375efac3c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.