Closed
Bug 432425
Opened 13 years ago
Closed 6 years ago
Remove browser_sanitize-download-history.js
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: Gavin, Assigned: Paolo)
References
Details
Attachments
(1 file)
6.46 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
See e.g. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1210055040.1210058195.22882.gz&fulltext=1 It's been failing intermittently since it was landed (bug 431729). Could be a timing issue, given that it uses a setTimeout. I've disabled it for now.
Comment 1•13 years ago
|
||
shouldn't be a timeout issue since it uses a setTimeout of zero so the load handlers fire
Reporter | ||
Comment 2•13 years ago
|
||
A setTimeout of 0 is a setTimeout of 10ms, and it can still introduce races if the machine is heavily bogged down (which is the case for the Linux unit test machines).
Assignee | ||
Updated•6 years ago
|
Summary: browser_sanitize-download-history.js failing intermittently on Linux tinderbox → Remove browser_sanitize-download-history.js
Assignee | ||
Comment 3•6 years ago
|
||
This test has been disabled for quite some time, and it cannot be re-enabled because it uses nsIDownloadManager. There is no point in having the file in the tree. Other existing tests, rather than one with an intermittent failure, are a better starting points if we ever want to write a front-end test for this functionality.
Assignee | ||
Comment 4•6 years ago
|
||
This is part of the work to remove all references to nsIDownloadManager.
Updated•6 years ago
|
Iteration: --- → 37.2
Updated•6 years ago
|
Iteration: 37.2 → 37.3
Reporter | ||
Updated•6 years ago
|
Attachment #8540168 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 5•6 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4bfed036e49 https://hg.mozilla.org/integration/fx-team/rev/5ff375efac3c
Comment 6•6 years ago
|
||
strange, I was sure to have marked this patch yesterday... somehow my changes were not submitted...
https://hg.mozilla.org/mozilla-central/rev/5ff375efac3c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in
before you can comment on or make changes to this bug.
Description
•