432425 - Remove browser_sanitize-download-history.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See e.g. http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1210055040.1210058195.22882.gz&fulltext=1

It's been failing intermittently since it was landed (bug 431729). Could be a timing issue, given that it uses a setTimeout. I've disabled it for now.

Comment 1

[Shawn Wilsher :sdwilsh]

shouldn't be a timeout issue since it uses a setTimeout of zero so the load handlers fire

Comment 2

[:Gavin Sharp [email: [e-mail]]]

A setTimeout of 0 is a setTimeout of 10ms, and it can still introduce races if the machine is heavily bogged down (which is the case for the Linux unit test machines).

Comment 3

[:Paolo Amadini]

Attachment: The patch

This test has been disabled for quite some time, and it cannot be re-enabled because it uses nsIDownloadManager.

There is no point in having the file in the tree. Other existing tests, rather than one with an intermittent failure, are a better starting points if we ever want to write a front-end test for this functionality.

Comment 4

[:Paolo Amadini]

This is part of the work to remove all references to nsIDownloadManager.

Comment 5

[:Paolo Amadini]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f4bfed036e49

https://hg.mozilla.org/integration/fx-team/rev/5ff375efac3c

Comment 6

[Marco Bonardo [:mak]]

strange, I was sure to have marked this patch yesterday... somehow my changes were not submitted...

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5ff375efac3c