Closed
Bug 432693
Opened 17 years ago
Closed 17 years ago
Cmd+? should be used for cmd_openHelp
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(1 file)
3.01 KB,
patch
|
mnyromyr
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
On mac, we display Cmd+? in the menu but map the command to cmd+Shift+/ (for en-US). This is done in suite/common/mac/platformCommunicatorOverlay.xul. However, it seems that we don't need this anymore - it actually probably prevents the shortcut from working now. See bug 432112, where this was removed for Firefox. Unfortunately, this doesn't work yet on certain keyboard layouts. See bug 432632, for example. Note also bug 432388, which is supposed to fix some layouts according to bug 432632, comment #5.
Assignee | ||
Comment 1•17 years ago
|
||
We should of course wait and see what happens here. I'd like to be able to open Help too ;-)
Assignee | ||
Comment 2•17 years ago
|
||
There is no ui change here, we just re-map the command. I also cleaned up the comments. Bug 432632 is fixed now, so this works fine on my sv-SE keyboard. It should also work with your keyboard layout, since the issue in bug 432632, comment #2 should have been fixed by bug 432388...
Attachment #320183 -
Flags: review?(mnyromyr)
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → seamonkey2.0alpha
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 3•17 years ago
|
||
Comment on attachment 320183 [details] [diff] [review]
re-map the command and do some clean-up
In fact, on a German keyboard, / is actually Shift-7, thus Cmd-Shift-/ == Cmd-Shift-7 == Cmd-/ and as such is a rather weird combination for help. Cmd-? is actually Cmd-Shift-ß and as such works.
With your patch, Cmd-? still works and the erroneous Cmd-/ is gone.
You'd probably want a second review from someone with an English/American keyboard.
Attachment #320183 -
Flags: review?(mnyromyr) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #320183 -
Flags: superreview?(jag)
Comment 4•17 years ago
|
||
Comment on attachment 320183 [details] [diff] [review]
re-map the command and do some clean-up
I guess there's no need to update /xpfe/communicator/resources/content/mac/platformCommunicatorOverlay.xul
sr=jag
Attachment #320183 -
Flags: superreview?(jag) → superreview+
Assignee | ||
Comment 5•17 years ago
|
||
Checking in suite/common/mac/platformCommunicatorOverlay.xul;
/cvsroot/mozilla/suite/common/mac/platformCommunicatorOverlay.xul,v <-- platformCommunicatorOverlay.xul
new revision: 1.17; previous revision: 1.16
done
Checking in suite/locales/en-US/chrome/common/mac/platformCommunicatorOverlay.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/mac/platformCommunicatorOverlay.dtd,v <-- platformCommunicatorOverlay.dtd
new revision: 1.12; previous revision: 1.11
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•