432724 - In Privacy tab of Preferences, "Download History" should be dependent on its "Browsing History" parent

Status: RESOLVED INACTIVE

(Firefox :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

See https://bugzilla.mozilla.org/show_bug.cgi?id=432427#c1

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008050704 Minefield/3.0pre

Summary: In Privacy tab of Preferences, "Download History" should be dependent on its "Browsing History" parent 

Steps to Reproduce:

1. Go to "Preferences"/"Options", "Privacy" tab, and click on the "Settings..." button under "Private Data"
2. Examine the preferences for "Browsing History" and "Download History"

Expected Results:

As in the "Tools", "Clear Private Data" dialog, "Download History" should be dependent on "Browsing History"--it should be inset, and, if you select "Browsing History", it should be checked.

Actual Results:

"Download History" and "Browsing History" are on separate lines and there's no dependency.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think this is worth relnoting - removing keyword.

Comment 3

[fred]

What, at first, seems to be a minor bug, may in fact have huge consequences: Suppose you wanted to clear your browsing history, but actually KEEP your download history, this is no longer possible: FF3 will always clear both.

The way I see it, the real bug is not the checkbock which is not inset and greyed out (although this is confusing). The real bug is that there is no way to maintain your list of downloaded files and still clear your browsing history. This was possible ion FF2. (I think, therefore, that Bug 45398 is only in parts a duplicate; it also mentions the dependency of the "download history" on the "browsing history" as malfunction.)

Comment 4

[Simon Bünzli]

(In reply to comment #3)
> The real bug is that there is no way to maintain your list of downloaded files
> and still clear your browsing history.

FTR: That's bug 456395.

Comment 5

[Nochum Sossonko [:Natch]]

the "Remember What I've downloaded" option on the Privacy tab should probably also be dependent on the history option above it, should i file a separate bug?

Comment 7

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> What, at first, seems to be a minor bug, may in fact have huge consequences:
> Suppose you wanted to clear your browsing history, but actually KEEP your
> download history, this is no longer possible: FF3 will always clear both.
> 
> The way I see it, the real bug is not the checkbock which is not inset and
> greyed out (although this is confusing). The real bug is that there is no way
> to maintain your list of downloaded files and still clear your browsing
> history. This was possible ion FF2. (I think, therefore, that Bug 45398 is only
> in parts a duplicate; it also mentions the dependency of the "download history"
> on the "browsing history" as malfunction.)
That is the intended behavior from bug 251337

Comment 8

[:Gavin Sharp [email: [e-mail]]]

...but see also bug 465995.

Comment 9

[(no longer active)]

Attachment: Patch (v1)

Make the Downloads checkbox dependent on the History checkbox.

Comment 10

[Shawn Wilsher :sdwilsh]

This shouldn't need UI review.  It's clearly a bug in our code.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

The dependency needs to be visually apparent by indenting the download history option, similar to how third party cookies is indented under accepting cookies.

Comment 12

[(no longer active)]

(In reply to comment #11)
> The dependency needs to be visually apparent by indenting the download history
> option, similar to how third party cookies is indented under accepting cookies.

I thought that at first, but wouldn't it be odd given the current grid layout?  Indenting that control would make the entire checkbox set to appear as randomly positioned, IMHO.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah visually it really isn't great, but it does make the dependency more expected. I don't have a strong opinion, especially if we are able to eventually decouple these so that there isn't a dependency in the future.

Comment 14

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 422874 [details] [diff] [review]
Patch (v1)

ui is fine to prevent dataloss, but ultimately we should get these to no longer have a dependency.

Comment 15

[Shawn Wilsher :sdwilsh]

(In reply to comment #14)
> (From update of attachment 422874 [details] [diff] [review])
> ui is fine to prevent dataloss, but ultimately we should get these to no longer
> have a dependency.
Of course, doing this would regress bug 251337

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #15)
> (In reply to comment #14)
> > ultimately we should get these to no longer have a dependency.
> Of course, doing this would regress bug 251337

I don't think that's necessarily true. Either way, that's what bug 465995 is about.

Comment 17

[Tan Wei Lin Jason [:Ryuji]]

Fixing this bug will caused unintended and (to the user) unexpected data lost.

Comment 18

[(no longer active)]

Gavin: ping?

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 422874 [details] [diff] [review]
Patch (v1)

Seems like we should combined these into a single pref using the same approach as bug 490030 comment 8: turn the history checkbox into "Browsing and Download History", and then just hide/remove the download checkbox.

Comment 20

[(no longer active)]

There's a little chance that I can work on this in any reasonable amount of time.  Throwing it back into the pool.

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.