432877 - Custom recurrence description is broken (regression)

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Simon Paquet [:sipaq]]

With the current nightly (2008-05-07-20) the recurrence description for custom recurrences is broken. It still works in the previous nightly (2008-05-06-18). I get the following information message:

No chrome package registered for chrome://1/locale/sun-calendar-event-dialog.properties

and the following error messages depending on the chosen recurrence range option:

Error: Failed to read 'repeatDetailsRuleDaily3' from 'chrome://calendar/locale/sun-calendar-event-dialog.properties'. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 1129"  data: no]
Source File: chrome://calendar/content/calUtils.js
Line: 1136

Error: Failed to read 'repeatDetailsInfinite' from 'chrome://calendar/locale/sun-calendar-event-dialog.properties'. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 1129"  data: no]
Source File: chrome://calendar/content/calUtils.js
Line: 1136

Error: Failed to read 'repeatDetailsCount' from 'chrome://calendar/locale/sun-calendar-event-dialog.properties'. Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 1129"  data: no]
Source File: chrome://calendar/content/calUtils.js
Line: 1136

Error: Failed to read 'repeatDetailsUntil' from 'chrome://calendar/locale/sun-calendar-event-dialog.properties'. Error: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIStringBundle.formatStringFromName]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://calendar/content/calUtils.js :: calGetString :: line 1129"  data: no]
Source File: chrome://calendar/content/calUtils.js
Line: 1136

This happens for kinds of recurrences (daily, weekly, monthly, etc.)

Checkins during that time: http://tinyurl.com/6oq4pj
I suspect either bug 428715, bug 430805 or bug 426746.

Steps to reproduce:
1. Open event dialog
2. Choose Repeat -> Custom
3. Define a recurrence and click "OK"
4. There you go!

Recurring events are still properly created, so this is mainly a display issue in the event dialog.

Comment 1

[Stefan Sitter [:ssitter]]

Regression range:

  Works in Sunbird 0.9pre (2008-05-07-12)
  Fails in Sunbird 0.9pre (2008-05-07-20)

Probably caused by Bug 377761 that changed the behavior of calGetString().

Comment 2

[Stefan Sitter [:ssitter]]

Error is in calendar-dialog-utils.js. 

There are many calls that pass a 4th parameter to calGetString(), e.g. http://mxr.mozilla.org/mozilla1.8/source/calendar/base/content/calendar-dialog-utils.js#415.

This parameter was neither required nor evaluated before. But with the changes made in Bug 377761 it's now interpreted as the optional stringbundle component name.

Comment 3

[Daniel Boelzle [:dbo]]

Attachment: fix

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 320118 [details] [diff] [review]
fix

Uhh..I wonder how that 1 got in there...

r=philipp

Comment 5

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH => FIXED.

Comment 7

[Decathlon]

I've just tried last build (2008051219) from

ftp://ftp.mozilla.org/pub/calendar/lightning/nightly/latest-mozilla1.8/windows-xpi/

and the bug is still present.

Comment 8

[Martin Schröder [:mschroeder]]

Missed calls for recurrence description:
http://mxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-dialog-utils.js#563

Other invalid calls:
http://mxr.mozilla.org/seamonkey/source/calendar/base/content/import-export.js#109
http://mxr.mozilla.org/seamonkey/source/calendar/base/content/import-export.js#180
http://mxr.mozilla.org/seamonkey/source/calendar/base/content/import-export.js#182

Comment 9

[Martin Schröder [:mschroeder]]

(In reply to comment #8)
> Missed calls for recurrence description:
> http://mxr.mozilla.org/seamonkey/source/calendar/base/content/calendar-dialog-utils.js#563
> 
> Other invalid calls:
> [...]

Now handled in bug 433462.