432893 - setup qm-vista02 on unittest staging

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Rob Campbell [:rc] (:robcee)]

we never did deploy qm-vista02 even though it's parked on a VMHost awaiting some setup. We will need to install a full set of development tools (Visual Studio, Mozilla-Build) as well as python and buildbot.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

I'd like to get on this - can someone give me a leg up in knowing how to access?

Comment 2

[Rob Campbell [:rc] (:robcee)]

I think we'll need to restart it on the vmhost. I can do that a little later and make sure it's not set to fall asleep.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

can we stick unit in the name somewhere?

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

please add this to the repository

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: patch to master.cfg to add the vista buildslave

and this

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 322999 [details]
mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

we don't want the pgo line at the bottom of this script. I realize it was a copy paste, but we should really remove  the --disable-composer and --disable-mailnews options.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 323000 [details] [diff] [review]
patch to master.cfg to add the vista buildslave

errant tab on line 91.

+vistaFactory.addStep(MozillaClobberWin,
+        workdir='.',
+        slaveName="slave",
+	platform="vista_stage",
+        env=MozillaEnvironments['mozbuild'])

some trailing spaces at end of lines should be trimmed.

Otherwise, this looks good.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: Spacing issue on line 91 fixed for master.cfg

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

as per your comment I took out the offending lines

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 323153 [details]
mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

please upload as a patch or at least as something viewable.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

hope this one works

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 323390 [details]
mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

ah, that's better. Change the comment at the top to match the name of your file, i.e., mozconfig-vista.

Is there a specific reason for the --disable-xpconnect-idispatch, activex, etc? I thought the activex codepaths were disabled by default. I'm a little worried that if we're disabling accessibility, we might burn some a11y tests in the near future.

at any rate, this should be good to go.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

I was going with the instructions here:
http://developer.mozilla.org/en/docs/atlbase.h

When I did a local build, there were error messages that pointed me to that article.  On my build, disabling code that uses atl did make the build work.

Comment 14

[Rob Campbell [:rc] (:robcee)]

that's likely because you were using the Express version of VisualC++? I seem to remember you were using VC9 on your local machine though you may have updated to a full version.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: mozconfig-vista to add to tools/buildbot-configs/testing/unittest-stage

true.  forgot that small detail.  here's a new one to try without the atl lines.  could this be the most versions of a mozconfig ever?

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

qm-vista02 launched, but errors out on cvs checkout.  

errors say "cannot mkdir -p logs because dir -p already exists" so it seems that 
http://mxr.mozilla.org/mozilla/source/tools/buildbot-configs/testing/unittest-stage/mozbuild.py#148

is the culprit.

have taken it offline for further investigation.

Comment 17

[Lukas Blakk [:lsblakk] use ?needinfo]

qm-vista02 is now a functioning member of society.  Closing.

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: [checked in] Adds vista to master.cfg for unittest staging

This one has been tested and works on unittest staging.

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Reopening because I had forgotten to do have the patch checked in.  Unittest staging is currently running with vista on a local patch.

Comment 20

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 325638 [details] [diff] [review]
[checked in] Adds vista to master.cfg for unittest staging

Checking in master.cfg;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest-stage/master.cfg,v  <--  master.cfg
new revision: 1.10; previous revision: 1.9
done