Closed Bug 432903 Opened 12 years ago Closed 11 years ago

Import wizard have "mail and address books" in the list even when choosing to import "settings"

Categories

(Thunderbird :: Migration, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: gkw, Assigned: gkw)

Details

Attachments

(1 file, 2 obsolete files)

Occurred on Vista SP1 while testing Shredder Alpha 1 build 1, with build ID
version 3.0a1 (2008050715).

Go to Tools -> Import. Clicking any of "Address book", "Mail" or "Settings" leads to:

- Eudora mail and address books
- Outlook mail and address books
- Outlook Express mail and address books

which is not informative since I can have chosen "Settings" and all three options would not make sense. They should name correctly for the relevant option chosen.
Flags: wanted-thunderbird3?
I don't think this is a priority for 3, but patches are welcome.
Flags: wanted-thunderbird3? → wanted-thunderbird3-
Summary: Import wizard naming errors. → Import wizard have "mail and address books" in the list even when choosing to import "settings"
Perhaps change "Eudora mail and address books" to "Eudora mail, address books and settings", applying the same concept for Outlook & Outlook Express?

CC'ing clarkbw on this, I should be able to whip up a quick fix once Bryan approves of an alternative name.

ref: http://mxr.mozilla.org/comm-central/search?string=mail+and+address+books&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
That looks good to me.  Just one small nit to use serial commas [1] 

"Eudora mail, address books, and settings"

Also, does this same change need to be made to the other items in the list?

[1] http://en.wikipedia.org/wiki/Serial_comma
(In reply to comment #3)
> Also, does this same change need to be made to the other items in the list?

Yes, so they'd become:

Eudora mail, address books, and settings
Outlook mail, address books, and settings
Outlook Express mail, address books, and settings
OS: Windows Vista → All
Hardware: x86 → All
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → nth10sd
Status: NEW → ASSIGNED
Attachment #354842 - Flags: review?
Attachment #354842 - Flags: review? → review?(bugzilla)
Attachment #354842 - Flags: review?(bugzilla) → review-
Comment on attachment 354842 [details] [diff] [review]
patch

-  // nsString  desc = "Outlook Express mail and address books";
+  // nsString  desc = "Eudora mail, address books, and settings";
   // *name = ToNewUnicode(desc);

These sorts of comments we can just drop. They aren't going to be implemented as that would be a regression.

 # Description of import module
 ## @name EUDORAIMPORT_DESCRIPTION
 ## @loc None
-2001=Eudora mail and address books
+2001=Eudora mail, address books, and settings

Standard l10n rules these days say that if you change the context of the string you should change the name as well.

I'll give you two choices:

a) Change the strings from having numbers as property names, to having real names (which would be nicer cleanup, but a bigger patch).

b) Change the number used for the string name.
Attached patch better patch (obsolete) — Splinter Review
Here's a better patch that addresses Standard8's comments. I removed the unnecessary comments, realigned the numbers in the .h files and chose to bump the numbers for the .properties files.
Attachment #354842 - Attachment is obsolete: true
Attachment #354945 - Flags: review?(bugzilla)
Comment on attachment 354945 [details] [diff] [review]
better patch

>+#define  OEIMPORT_NAME                       2000
>+#define  OEIMPORT_DESCRIPTION                2011
>+#define OEIMPORT_MAILBOX_SUCCESS             2002

nit: I think the OEIMPORT can all be aligned - no need for double space. Ditto in nsOutlookStringBundle.h.
Attachment #354945 - Flags: review?(bugzilla) → review+
Final patch that fixes the nits Standard8 mentioned.
Attachment #354945 - Attachment is obsolete: true
Attachment #355558 - Flags: review+
Attachment #355558 - Flags: superreview?(bienvenu)
Attachment #355558 - Flags: superreview?(bienvenu) → superreview+
Keywords: checkin-needed
Comment on attachment 355558 [details] [diff] [review]
final patch
[Checkin: Comment 10]

http://hg.mozilla.org/comm-central/rev/9cd8140b3254
Attachment #355558 - Attachment description: final patch → final patch [Checkin: Comment 10]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.