Closed Bug 433065 Opened 12 years ago Closed 11 years ago

remove support for -moz-pre-wrap

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: Gavin, Assigned: crazy-daniel)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

See bug 418543. That bug removed a bunch of in-tree references, this bug is about removing support for it entirely.
Flags: wanted1.9.1?
Flags: wanted1.9.1?
Flags: wanted1.9.1-
Flags: blocking1.9.1-
I think this'd be best before beta builds are released. It should also be possible to combine this with Bug 413141. Anyway, my last comment on this.
Attached patch trying to remove -moz-pre-wrap (obsolete) — Splinter Review
This patch should remove all remnants of -moz-pre-wrap, I hope it is correct.

Sorry for my spam earlier. I think I finally got it.
Attachment #340635 - Flags: superreview?(bzbarsky)
Attachment #340635 - Flags: review?(bzbarsky)
Attachment #340635 - Flags: superreview?(bzbarsky)
Attachment #340635 - Flags: superreview+
Attachment #340635 - Flags: review?(dbaron)
Attachment #340635 - Flags: review?(bzbarsky)
Comment on attachment 340635 [details] [diff] [review]
trying to remove -moz-pre-wrap

This looks ok, but there are some nsIDocumentEncoder.idl comments that could use fixing too, and this probably needs moa from dbaron.
Attached patch v2 (obsolete) — Splinter Review
(In reply to comment #3)
> (From update of attachment 340635 [details] [diff] [review])
> This looks ok, but there are some nsIDocumentEncoder.idl comments that could
> use fixing too

There was only one line to be changed. However, I did a more careful search and found some appearances of moz-pre-wrap in htmlparser/tests and nsPlainTextSerializer.css - nothing special, though.

Should I ask for another sr here?
Attachment #340635 - Attachment is obsolete: true
Attachment #340707 - Flags: review?(dbaron)
Attachment #340635 - Flags: review?(dbaron)
Attached patch v3Splinter Review
Of course we want -moz-pre-wrap to go away...
Attachment #340707 - Attachment is obsolete: true
Attachment #340722 - Flags: superreview?(bzbarsky)
Attachment #340722 - Flags: review?(dbaron)
Attachment #340707 - Flags: review?(dbaron)
Attachment #340722 - Flags: superreview?(bzbarsky) → superreview+
Attachment #340722 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/mozilla-central/rev/e57e250218c4
Assignee: nobody → crazy-daniel
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
So, this breaks three non-Firefox consumers...
My apologies, I didn't realise that bug 418543 had converted all consumers (at least, all the ones that were includeded in comm-central mxr at the time).
The two in comment 10 are fine, and should stay as they are, I think, since those extensions try to be compatible with old versions of Mozilla as well as current ones.

Somebody should patch calendar-views.css, though.
Depends on: 458404
Ah, looks like it was done in bug 458404.
Does this mean that -moz-pre-wrap no longer works at all, or just that we don't use it internally?  It's currently documented as deprecated.
(In reply to comment #14)
> Does this mean that -moz-pre-wrap no longer works at all

Yep. People can still use it in order to support gecko 1.8.*, but for 1.9.1 they need to add pre-wrap, if it's not already there -- which it should, for other browsers.
Docs have removed this from the list of supported values now, although notes are in place suggesting including it when using pre-wrap for backward compatibility purposes.
You need to log in before you can comment on or make changes to this bug.