remove support for -moz-pre-wrap

RESOLVED FIXED in mozilla1.9.1b1

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Gavin, Assigned: Daniel.S)

Tracking

({dev-doc-complete})

Trunk
mozilla1.9.1b1
dev-doc-complete
Points:
---
Bug Flags:
blocking1.9.1 -
wanted1.9.1 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

See bug 418543. That bug removed a bunch of in-tree references, this bug is about removing support for it entirely.
(Assignee)

Updated

10 years ago
Flags: wanted1.9.1?
Flags: wanted1.9.1?
Flags: wanted1.9.1-
Flags: blocking1.9.1-
(Assignee)

Comment 1

10 years ago
I think this'd be best before beta builds are released. It should also be possible to combine this with Bug 413141. Anyway, my last comment on this.
(Assignee)

Comment 2

10 years ago
Created attachment 340635 [details] [diff] [review]
trying to remove -moz-pre-wrap

This patch should remove all remnants of -moz-pre-wrap, I hope it is correct.

Sorry for my spam earlier. I think I finally got it.
Attachment #340635 - Flags: superreview?(bzbarsky)
Attachment #340635 - Flags: review?(bzbarsky)
Attachment #340635 - Flags: superreview?(bzbarsky)
Attachment #340635 - Flags: superreview+
Attachment #340635 - Flags: review?(dbaron)
Attachment #340635 - Flags: review?(bzbarsky)
Comment on attachment 340635 [details] [diff] [review]
trying to remove -moz-pre-wrap

This looks ok, but there are some nsIDocumentEncoder.idl comments that could use fixing too, and this probably needs moa from dbaron.
(Assignee)

Comment 4

9 years ago
Created attachment 340707 [details] [diff] [review]
v2

(In reply to comment #3)
> (From update of attachment 340635 [details] [diff] [review])
> This looks ok, but there are some nsIDocumentEncoder.idl comments that could
> use fixing too

There was only one line to be changed. However, I did a more careful search and found some appearances of moz-pre-wrap in htmlparser/tests and nsPlainTextSerializer.css - nothing special, though.

Should I ask for another sr here?
Attachment #340635 - Attachment is obsolete: true
Attachment #340707 - Flags: review?(dbaron)
Attachment #340635 - Flags: review?(dbaron)
(Assignee)

Comment 5

9 years ago
Created attachment 340722 [details] [diff] [review]
v3

Of course we want -moz-pre-wrap to go away...
Attachment #340707 - Attachment is obsolete: true
Attachment #340722 - Flags: superreview?(bzbarsky)
Attachment #340722 - Flags: review?(dbaron)
Attachment #340707 - Flags: review?(dbaron)
Attachment #340722 - Flags: superreview?(bzbarsky) → superreview+
Attachment #340722 - Flags: review?(dbaron) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/e57e250218c4
Assignee: nobody → crazy-daniel
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed → dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1

Comment 8

9 years ago
So, this breaks three non-Firefox consumers...
My apologies, I didn't realise that bug 418543 had converted all consumers (at least, all the ones that were includeded in comm-central mxr at the time).
The two in comment 10 are fine, and should stay as they are, I think, since those extensions try to be compatible with old versions of Mozilla as well as current ones.

Somebody should patch calendar-views.css, though.
(Assignee)

Updated

9 years ago
Depends on: 458404
Ah, looks like it was done in bug 458404.
Does this mean that -moz-pre-wrap no longer works at all, or just that we don't use it internally?  It's currently documented as deprecated.
(In reply to comment #14)
> Does this mean that -moz-pre-wrap no longer works at all

Yep. People can still use it in order to support gecko 1.8.*, but for 1.9.1 they need to add pre-wrap, if it's not already there -- which it should, for other browsers.
Docs have removed this from the list of supported values now, although notes are in place suggesting including it when using pre-wrap for backward compatibility purposes.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.