433070 - Cannot import passwords from Seamonkey

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[Bruno Calvignac]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.14) Gecko/20080508 Firefox/2.0.0.14 Flock/1.2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.14) Gecko/20080508 Firefox/2.0.0.14 Flock/1.2pre

 

Reproducible: Always

Steps to Reproduce:
1.Start FF3 with a new profile (don't import anything)
2.Select File/Import and choose Seamonkey
Actual Results:  
Passwords are not imported

Expected Results:  
Passwords are imported

Comment 1

[Bruno Calvignac]

Attachment: fix

Comment 2

[WADA:World Anti-bad-Duping Agency]

To Bruno Calvignac(bug opener & who proposed a patch):

Will your patch resolve Bug 435143(and Bug 434911 too)?

Comment 3

[Bruno Calvignac]

I can't say for sure but it might. It's anyway definitely related and should be fixed before looking at those other 2 bugs.

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 320259 [details] [diff] [review]
fix

Actually need to set a reviewer to get it reviewed.

Comment 5

[Justin Dolske [:Dolske]]

(In reply to comment #2)

> Will your patch resolve Bug 435143(and Bug 434911 too)?

I think this will fix those too.

Comment 6

[Lisa S]

Please forgive my ignorance, I don't know how to make use of the information to solve the same problem on my computer.

Comment 7

[WADA:World Anti-bad-Duping Agency]

Lisa S, see Bug 435143 Comment #0, (Phenomenon-3).

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 320259 [details] [diff] [review]
fix

r=me. This code isn't very good at checking rvs for clone/createInstance, but I suppose those typically only fail in OOM cases. Worth a followup bug on adding some rv checks here perhaps?

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d659c7e3e5d4

Comment 10

[WADA:World Anti-bad-Duping Agency]

I couldn't reproduce bug 435143 and bug 434911 with next build.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090623 Minefield/3.6a1pre