434911 - Exception in nsIBrowserProfileMigrator.migrate when both of "Saved Passwords" and "Bookmarks" are chosen at File/Import/"Netscape 6,7 or Mozilla 1.x"

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[WADA:World Anti-bad-Duping Agency]

Build ID: (Win32 ZIP build on MS Win-XP SP2)
> Vendor=Mozilla, Name=Firefox, Version=3.1a1pre, BuildID=2008052003

File/Import/"Netscape 6,7 or Mozilla 1.x" fails to import bookmark from Seamonkey 1.1.9 profile, when profile name of Seamonkey is other than "Default User".
Following message is issued on Error Console when other than "Default User".
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIBrowserProfileMigrator.migrate]"
> nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> chrome://browser/content/migration/migration.js :: anonymous :: line 367" data: no]
And bookmark folder of "From Netscape 6/7/Mozilla" becomes (empty).

Bugs who have "bookmark && import" in bug summary, such as Bug 348486, Bug 380140, Bug 404587, Bug 423211, are possibly same issues, but I could't find any description about "Default Users" nor above Exception in them. So I report above phenomenon as new bug. Please close as DUP if same problem as already opened bug.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Condition when problem occurs was incorrect, and problem I explained in comment #0 was inaccurate.
Profile name itself didn't have relation to problem.
Problem(above exception) occurred even when newly created/used "Default User", if SignonFile(11331489.s in test case) exists.
And, because order in dialog is "Cookies", "Saved Passwords", "Bookmarks" and migration seems to be executed in this order, empty bookmark folder perhaps is merely a result of exception at password import step.

>Seamonkey Profile ("Default User")
> %APPDATA%\Mozilla\registry.dat
> %APPDATA%\Mozilla\Profiles\Default User\vao2f9nv.slt
> %APPDATA%\Mozilla\Profiles\Default User\vao2f9nv.slt\prefs.js
>           user_pref("signon.SignonFileName", "11331489.s");
> %APPDATA%\Mozilla\Profiles\Default User\\vao2f9nv.slt\11331489.s
> Note: Master Password is not used

When profile is newly created, file of 11331489.s doesn't exist in profile. At this step, File/Import by Firefox trunk was successful. After creation of 11331489.s(null file), File/Import by Firefox trunk failed with above exception, and following file was generated.
> %APPDATA%\Mozilla\Profiles\Default User\11331489.s
Content of the file;
> #2e
> .
File content was same for null xxxxxxx.s file case("Default User") and daily using non-null file case(my daily use profile).

Top part of xxxxxxxx.s file in daily use profile is as follows. This file is initially created by Mozilla 0.x, and used by Mozilla 1.x, and used by Seamonkey 1.0/1.1. This content can be a cause of exception.
> #2c
> http://cgi.f51.aaacafe.ne.jp
> http://f51.aaa.livedoor.jp
> http://forum.mozilla.gr.jp
> http://mozilla.gr.jp
> http://piro.sakura.ne.jp
> http://white.sakura.ne.jp
> http://www.gay-jp.net
> http://www.kakaku.com
> https://secure2.dti.ad.jp
> https://webkit.dti.ne.jp
> isweb5.infoseek.co.jp
> mozilla.gr.jp
> www.mozilla.gr.jp
> .
> 192.168.0.1:80
> \=username=\
>(fields/password data follows) 

Comment 2

[WADA:World Anti-bad-Duping Agency]

Correction of explanation of condition & problem again. Sorry for spam.

Problem-1 : (This bug, Exception in File/Import)
When both of "Saved Passwords" and "Bookmarks" are chosen at File / Import / "Netscape 6,7 or Mozilla 1.x", exception in comment #0 occurs.
And, no password is imported(=Problem-2), and bookmark folder of "From Netscape 6/7/Mozilla" becomes (empty).
When one of "Cookies", "Saved Passwords", "Bookmarks" only, or when "Cookies" & "Saved Passwords", or when "Cookies" & "Bookmarks", no exception occurs.
When no xxxxxxxx.s, "Saved Passwords" can not be chosen. So problem won't occur when no xxxxxxxx.s file.

Problem-2 :
"Saved Passwords" of File/Import/"Netscape 6,7 or Mozilla 1.x" doesn't import password(xxxxxxxx.s) from correct xxxxxxxx.s file in profile directory of Seamonky 1.x.
When xxxxxxxx.s is copied to from correct (a) to (b), passwords are imported.
> (a) %APPDATA%\Mozilla\Profiles\Default User\vao2f9nv.slt\11331489.s
> (b) %APPDATA%\Mozilla\Profiles\Default User\11331489.s
I'll open bug for problem-2.

Comment 3

[WADA:World Anti-bad-Duping Agency]

"chrome://browser/content/migration/migration.js :: anonymous :: line 367" is perhaps following code.
> 365 onMigratingMigrate: function (aOuter)
> 366   {
> 367     aOuter._migrator.migrate(aOuter._itemsFlags, aOuter._autoMigrate, aOuter._selectedProfile);
> 368   },

I guess following is cause of Exception.
(1) "Passwords" step changes processing profile directory to "Default User"
    from correct "Default User\vao2f9nv.slt". (then Problem-2 occurs)
(2) Thus Exception occurs when try to go to "Bookmark" step.

Comment 4

[WADA:World Anti-bad-Duping Agency]

I've opened Bug 435143 for Problem-2.

Comment 5

[WADA:World Anti-bad-Duping Agency]

Problem is not reproduced by next build. Fixed by Bug 433070.
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090623 Minefield/3.6a1pre