433256 - copy using command+c in a pop-up window's address field fails

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Asa Dotzler [:asa]]

Command+C fails to copy the text from the addressbar in a pop-up window on Mac latest nightly build

steps
1. visit http://www.quirksmode.org/js/popup.html
2. scroll down to the "Open popup" link and click it
3. in the resulting pop-up window, select the address text (note that single click select entire field also fails here)
4. use the keyboard command+c to copy the text (note the flash of the Edit menu on the Mac Firefox menubar)
5. go to any textfield and ctrl+v or edit->paste

results.
Fails to paste

additional info: using Edit->copy from the Mac Firefox menubar works. it's just the keyboard shortcut that fails.

Also, I've seen this around the web. the quirksmode site was just an easy testcase since I happened to be there.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Are we sure this isn't just OSX focus strangeness?
Is there anything in the error console?

Comment 2

[Asa Dotzler [:asa]]

I don't think it could be a focus issue since the actual menu command works but the keyboard doesn't. No errors in the JS Console. 

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Yeah, I can confirm this on other popup windows as well.

Asa: how long have you been noticing this for? Can we hunt down a regression range, please?

Johnath: we added the locationbar on popups a long time ago, any chance that this is related to that addition?

(Either way, I don't think this blocks final release)

Comment 4

[Johnathan Nightingale [:johnath]]

(In reply to comment #3)
> Yeah, I can confirm this on other popup windows as well.
> 
> Asa: how long have you been noticing this for? Can we hunt down a regression
> range, please?
> 
> Johnath: we added the locationbar on popups a long time ago, any chance that
> this is related to that addition?

You're talking about bug 337344 which toggled the "dom.disable_window_open_feature.location" pref so that we always show the location bar by default.  That is certainly what causes this bug to be visible in the default case, however I don't think that bug is the cause.  Toggling that pref in FF2 gives me a location bar which still responds to copy requests, so it seems like there is likely some other regression at work here.

I sort of suspect these lines:

http://mxr.mozilla.org/mozilla/source/browser/base/content/browser.js#779

...because if you go to the bottom of the quirksmode page, where it lets you specify the arguments to pass in, and you check the "toolbar" box (which would change the code execution here) then everything works as it should.

CVS blame says those lines were moved there (from delayedStartup()) in bug 419990 which landed March 11, so if a build from Mar 10 works and a build from Mar 12 doesn't, that'd be a strong hint.  The code already existed, but maybe moving them to BrowserStartup() broke something timing-specific?

Comment 5

[Ken Edwards]

Attachment: URL selected in popup without outline of text box

Comment 6

[Ken Edwards]

I came by today to report this exact same bug, but found this report. There are some other strange things I'm seeing happen in a popup window related to the URL field, so I'd like to add them here:

No Paste
- Although Edit->Copy works, Edit->Paste is grayed out.
- command+v results in a system "alert sound" with no flash of the Edit menu on the Mac Firefox menubar

I tried all the keyboard shortcuts that I saw in the menus and none of them worked when the text in the URL field was selected, but they did work when I had text in the web page selected. Note that command-q does work and it quits the program.

One last thing related to the URL field in popups, and this looks like a focus problem to me. As Asa originally noted, the single click select entire field fails in a popup window. One other thing that fails is the outlining in blue of the URL field text box, see url_no_outline.png. To get the outline, see url_yes_outline.png, I had to position my cursor so that it changed into a hand, this happened when I was on the edge of where the outline would be drawn. Once I clicked here, the outline would be drawn, and would not disappear, even if i went back and selected text in the web page area, see url_yes_outline_without_focus.png. This does not happen in a non-popup window.

Comment 7

[Ken Edwards]

Attachment: Outline of URL text box without focus

Comment 8

[Ken Edwards]

Attachment: URL selected in popup with outline of text box

Comment 9

[Steven Michaud [:smichaud] (Retired)]

Note that the popup window's (from comment #0 step 2) location bar
isn't editable on OS X, Windows or Linux (or presumably any other
platform).

This probably has something to do with the problem.

Comment 10

[Steven Michaud [:smichaud] (Retired)]

Note also bug 433934, which may be related.

Comment 11

[bomfog]

(In reply to comment #9)
> Note that the popup window's (from comment #0 step 2) location bar
> isn't editable on OS X, Windows or Linux (or presumably any other
> platform).

Two info-bits: The toolbar checkbox thing from comment #4 makes it editable on windows, as does setting dom.disable_window_open_feature.toolbar to true.

Comment 12

[Steven Michaud [:smichaud] (Retired)]

This bug started happening with the 2008-04-08-04-trunk nightly, and
appears to have been caused/triggered by the patch for bug 398514.  So
this appears to be a Cocoa widgets bug.

Among other things, this patch stopped giving the OS first crack at
key combinations like command-c and command-v, so that they would
(instead) get passed to Gecko (and to the JavaScript event handlers
for "clients" like Google's apps).

So command-c must be getting to Gecko.  The puzzle is why it's not
being acted on -- even though the equivalent menu item (Edit : Copy)
works just fine (and is enabled or disabled appropriately).

Josh, do you have any ideas?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has been fixed by the patch on bug 486395. Steven, can we mark this bug as a dupe? Works fine for me now with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090428 Minefield/3.6a1pre ID:20090428031037

Comment 14

[Steven Michaud [:smichaud] (Retired)]

This bug is definitely now fixed.