Closed
Bug 433308
Opened 17 years ago
Closed 16 years ago
Top/main mozilla.com nav is not localizable
Categories
(support.mozilla.org :: Localization, task)
support.mozilla.org
Localization
Tracking
(Not tracked)
RESOLVED
FIXED
0.6.1
People
(Reporter: djst, Assigned: djst)
References
()
Details
(Whiteboard: sumo_only)
Attachments
(1 file)
5.71 KB,
text/html
|
Details |
The main nav we're copying from Mozilla.com needs to be localizable.
Assignee | ||
Comment 1•16 years ago
|
||
After discussing this with Brian Krausz we decided to copy over the top nav from the main mozilla.com and make it localizable. This means that while it will be possible to localize the items, it will not be possible to add/remove menu items. This means that if you visit e.g. the Polish mozilla.com and go to SUMO, you won't have the exact same menu items because the Polish version of mozilla.com has additional support links under Support.
Comment 2•16 years ago
|
||
How about the plan about URL of the items?
Polish version is on mozilla.com but Japanese version isn't.
Mozilla Japan web site will use these URL for top/nav menu:
http://mozilla.jp/products/
https://addons.mozilla.jp/
http://mozilla.jp/support/
http://mozilla.jp/community/
http://mozilla.jp/about/
# and many other URLs for sub menus
# not https://www.mozilla.com/ja/products/ etc
We should use same URLs on SUMO too and we should make URLs localizable too.
And on Mozilla Japan website we use images not text string for top/nav title menu (like Apple etc site) since with Japanese default font the site looks poor for Japanese.
http://mozilla.l10n.jp/~dynamis/sumo/header-background.png
# copy of: http://stage.mozilla.jp/img/tignish/template/header-background.png
Assignee | ||
Comment 3•16 years ago
|
||
Nelson, is it possible to make the urls localizable too?
Comment 4•16 years ago
|
||
All:
I can easily stick in different content based on what locale you're viewing, even with different links (that was a miscommunication between djst and myself), the only issue is that if the links change on the main site they must also be changed on sumo via a code edit. Not a massive deal, but still a pain.
I'm going to have to dig through the MoCo SVN to find the current localized header code, does anyone happen to already have a list of headers with what links go where, etc?
Comment 5•16 years ago
|
||
(In reply to comment #4)
> I'm going to have to dig through the MoCo SVN to find the current localized
> header code, does anyone happen to already have a list of headers with what
> links go where, etc?
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/header.inc.php?view=markup
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/includes/header.inc.php?view=markup
http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/includes/l10n/main.lang?view=markup
Change "en-US" to other locale codes as appropriate.
Assignee | ||
Comment 6•16 years ago
|
||
(In reply to comment #4)
> All:
>
> I can easily stick in different content based on what locale you're viewing,
> even with different links (that was a miscommunication between djst and
> myself), the only issue is that if the links change on the main site they must
> also be changed on sumo via a code edit. Not a massive deal, but still a pain.
>
Thanks for clearing that up, Brian! Sorry about the confusion.
Comment 7•16 years ago
|
||
(In reply to comment #5)
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/includes/header.inc.php?view=markup
>
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/includes/header.inc.php?view=markup
>
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/includes/l10n/main.lang?view=markup
>
> Change "en-US" to other locale codes as appropriate.
I talked with other Mozilla Japan staffs about top/main nav of our Mozilla Japan (MJ) site. It's maybe only us but our MJ site are not generated from MoCo SVN. We have our own CVS and web server and we cannot generate correct nav menu from files in MoCo SVN.
MJ website use same top/nav menu items as MoCo ones but different submenus not only translation. We also have our own CSS for top/nav menu to make it looks fine in Japanese (see bug 438314).
Sorry for inconvenient but to make Japanese SUMO consistent with MJ site, we need to treat ja separately.
Here is a homepage html of new design (for Fx3) MJ site:
http://mozilla.l10n.jp/~dynamis/sumo/mozilla.jp/index.html
http://mozilla.l10n.jp/~dynamis/sumo/mozilla.jp/index.full.html
Later is the page saved with "Web Page, Complete".
# original is: http://stage.mozilla.jp/
# you need user/pass to see staging site and I'll mail it if you need
Note: You don't see text of the main nav since it's backgroud image:
http://mozilla.l10n.jp/~dynamis/sumo/header-background.png
but it's specified in css and "Web Page, Complete" isn't support saving files referenced in css files.
# Japanese text is much more complex than alphabet and looks ugly with some fonts and we use image like Apple site etc.
Comment 8•16 years ago
|
||
I looked into this, ja will need some hacks because of the background image, but I have setup a way to specify links/dropdowns for different locales that will be loaded dynamically. I need a list of these somehow, since they are in different places (I'll probably just have to go through and compile a big list). Does anyone know the URL for the mozilla-europe.org staging server.
Tomoya: can you send me the user/pass for the staging site?
Comment 9•16 years ago
|
||
https://stage.mozilla-europe.org
LDAP authentification, you probably need Mozilla IT to update your account with the appropriate rights
Comment 10•16 years ago
|
||
Note that we are using a modified version of mozilla.com menu to fit our localization needs (wider menus and per locale customization of support menu).
Comment 11•16 years ago
|
||
(In reply to comment #10)
> Note that we are using a modified version of mozilla.com menu to fit our
> localization needs (wider menus and per locale customization of support menu).
>
djst: how do we want to handle this:
1) We are using the wider header (don't know if that was me messing up or deliberate, but it looks nice so I'd say leave it)
2) Do we want to always use moco or localize to moz-europe for the top left?
3) Do we want to leave the search box for when we localize? (I don't know if there's room in some locales)
4) Considering the differences in a lot of things here, we're getting to the point where we may as well hard-code wording for locales instead of using translation, just because so much changes per locale. Thoughts?
Assignee: nobody → bkrausz
Assignee | ||
Comment 12•16 years ago
|
||
(In reply to comment #11)
>
> djst: how do we want to handle this:
>
> 1) We are using the wider header (don't know if that was me messing up or
> deliberate, but it looks nice so I'd say leave it)
I'm not sure if I understand what you mean with a wider header. I tried to compare the width of the top nav of the .psd mockups with what I see on e.g. https://www-firefox3.authstage.mozilla.com/en-US/firefox/features but the latter one looks bigger overall. Is that what you mean?
> 2) Do we want to always use moco or localize to moz-europe for the top left?
The "mozilla" link? It should go to the same place as the local mozilla.com equivalent IMO, meaning if you visit the French Mozilla.com, that link would take you to Mozilla Europe.
> 3) Do we want to leave the search box for when we localize? (I don't know if
> there's room in some locales)
I don't know the answer to this one. jslater, your thoughts here? I realize SUMO is going to get localized to more languages than mozilla.com, so maybe we'll be the first sub-site to spot potential problems.
> 4) Considering the differences in a lot of things here, we're getting to the
> point where we may as well hard-code wording for locales instead of using
> translation, just because so much changes per locale. Thoughts?
If by hard-coding, you mean e.g. separate template (or import) files that we would have to manage outside the main l10n systems on SUMO, that's totally fine with me. The people who would localize the top nav are the locale leaders and it's a one-time operation.
Thanks! Let me know if you have other questions.
Comment 13•16 years ago
|
||
(In reply to comment #12)
> > 3) Do we want to leave the search box for when we localize? (I don't know if
> > there's room in some locales)
> > I don't know the answer to this one. jslater, your thoughts here? I realize
> SUMO is going to get localized to more languages than mozilla.com, so maybe
> we'll be the first sub-site to spot potential problems.
My preference, of course, would be to keep the search box if possible, but you can definitely remove it if you need to. It's more important that the tabs look right and function correctly.
Comment 14•16 years ago
|
||
(In reply to comment #12)
> > 1) We are using the wider header (don't know if that was me messing up or
> > deliberate, but it looks nice so I'd say leave it)
> I'm not sure if I understand what you mean with a wider header. I tried to
> compare the width of the top nav of the .psd mockups with what I see on e.g.
> https://www-firefox3.authstage.mozilla.com/en-US/firefox/features but the
> latter one looks bigger overall. Is that what you mean?
Nevermind, I had zoom out set on the ff3 site...
> > 2) Do we want to always use moco or localize to moz-europe for the top left?
> The "mozilla" link? It should go to the same place as the local mozilla.com
> equivalent IMO, meaning if you visit the French Mozilla.com, that link would
> take you to Mozilla Europe.
But should it say "mozilla europe"? This will take away from the amount of space we have and possibly require me to remove the search box from the header for europe.
Status: NEW → ASSIGNED
Assignee | ||
Comment 15•16 years ago
|
||
My best recommendation would be to do the same as mozilla europe does it. Pascal, do you have any information here that could help? Thanks!
Comment 16•16 years ago
|
||
OK, moz europe it is.
Also, are all of the links/wording for mozilla-europe.org the same for all languages? If not, does anyone know what has changes from https://stage.mozilla-europe.org/en/? Ideally I'd love to be able to make 3 templates, moco, moz europe, and moz jp, and just switch between those 3 with localization.
Assignee | ||
Comment 17•16 years ago
|
||
Unfortunately that's likely not the case, as pascal showed me an example of how the Polish version of the top nav linked to their local Polish support website in the Support drop-down. :(
Comment 18•16 years ago
|
||
the menus are the same for all locales except for the support menu where our localizers can add their community support sites at the bottom of the list. Please ask Stas about the implementation but wait a couple of days because he has his final exams this week.
Assignee | ||
Comment 20•16 years ago
|
||
Brian, could we simply use a static html/txt file for the whole top nav that we phpinclude at the top of the page? That way we could just mail out this file to the localizers and have them create (or copy) their version based on the mozilla.com top nav and we could include it automatically.
Comment 21•16 years ago
|
||
I current have that structure setup on, though now only for English. There's a lot of html there, if they're ok burning through that I see no problem with that plan.
Assignee | ||
Comment 22•16 years ago
|
||
Since this is basically part of the mozilla.com website and will likely not change much (if at all), it sounds reasonable.
Especially if most Mozilla Europe locales can just grab the html from their website. Is it setup that way?
Assignee | ||
Updated•16 years ago
|
Priority: -- → P1
Target Milestone: --- → 0.7
Assignee | ||
Comment 23•16 years ago
|
||
Mass-moving P1 bugs to 0.6.1.
Priority: P1 → --
Target Milestone: 0.7 → 0.6.1
Comment 24•16 years ago
|
||
The technical functionality is here for this bug, closing as per discussion during bug triage.
The way the system is setup is that it looks for header_{$locale}.tpl. If found it loads it, if not loads the english version. We need to acquire the following from locale leaders:
1) A version of header_en-US.tpl (http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/templates/styles/mozcommon/) for the locale
2) Where the image in the top left should point, and if it should say mozilla or mozilla europe
3) Whether or not you want the right site-search and where it should point.
Alternatively, a link to a site with a version of the header would work.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 25•16 years ago
|
||
r17083 and r17093.
Localizers need to localize svn.mozilla.org/vc/projects/sumo/trunk/templates/styles/mozcommon/header_en-US.tpl to their language and change the en-US to their locale. Files put in this directory with this format will automatically be used for the appropriate locale.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 26•16 years ago
|
||
Reassigning as per comment #25
Assignee: bkrausz → nobody
Status: REOPENED → NEW
Component: General → Localization
QA Contact: general → localization
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Comment 27•16 years ago
|
||
I don't have SVN account, can I translate the file and upload here? Maybe could check in the revision for me...
Assignee | ||
Comment 28•16 years ago
|
||
(In reply to comment #27)
> I don't have SVN account, can I translate the file and upload here? Maybe could
> check in the revision for me...
>
You can just download the file, translate it and then e-mail it to me (or straight to Brian) and we can upload it and verify that it works. Let me know if you have any questions!
Comment 29•16 years ago
|
||
Another thing, the exact en-US file is
http://svn.mozilla.org/projects/sumo/trunk/templates/styles/mozcommon/header_en-US.tpl
I can't reach the last file Brian write on comment #25
Comment 30•16 years ago
|
||
Sorry, the "/vc" was a typo. Thanks for correcting.
Also, this is not resolved...don't know why it was marked as such (djst and I have been going back and forth over how to get the word out over this). Reopening and assigning to him, if this should be closed please do so and sorry for the bugspam :).
Updated•16 years ago
|
Assignee: nobody → djst
Status: REOPENED → NEW
Comment 31•16 years ago
|
||
Adding the tpl for "es" locale.
Review?
Attachment #332451 -
Flags: review?
Updated•16 years ago
|
Attachment #332451 -
Attachment mime type: application/octet-stream → text/html
Attachment #332451 -
Flags: review?(djst)
Assignee | ||
Comment 32•16 years ago
|
||
Hey Brian, I was under the impression that the logic to actually pick a localized version of the file if one exists was already implemented, hence marking this bug as FIXED. The actual work to _create_ these localized files for every locale should (IMO) not be part of this bug.
If you agree with this, and the backend part of actually supporting localized versions of the file is fixed, then we can safely mark this bug as fixed again. Chris and I will work out a plan for getting the info out to all localizers. Ideally the contributor doc http://support.mozilla.com/en-US/kb/Translating+the+interface should be updated with the info here.
Comment 33•16 years ago
|
||
The problem was that once this bug was marked as fixed everyone forgot about localizing the header. I don't remember what we decided to do about it in the end, I suppose that's your call.
Assignee | ||
Comment 34•16 years ago
|
||
Marking bug as fixed again. Sorry for the confusion! It looks like we have an "es" localization ready to be implemented to verify that this indeed works. willyaranda, could you please file a new bug for checking in the Spanish file and assign it to Nelson? Thanks!
Status: NEW → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #332451 -
Flags: review?(djst)
Attachment #332451 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Whiteboard: sumo_only
You need to log in
before you can comment on or make changes to this bug.
Description
•