433349 - Omnibus ad-blocking bug for May 2008

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Another month, another set of ads to block....

Comment 1

[philippe (part-time)]

http://www.excite.co.jp/world/ 
(Japanese-English/Korean/Chinese translation service)
they've now added an ad to the right of the input textarea.

a[href*="adimp.excite.co.jp"] {display:none !important;}

That also blocks a bunch of text only ads towards the bottom of the page.

Comment 2

[Chris Lawson (gone)]

Lots of ads on

http://www.stratfordbeaconherald.com/ArticleDisplay.aspx?e=1056576&auth=Laura+Cudworth%2C+STAFF+REPORTER

While the images themselves seem to be living in a fairly innocuous place, they're all linked to kestrel.ospreymedialp.com , so maybe we can use that somehow.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> a[href*="adimp.excite.co.jp"] {display:none !important;}
> 
> That also blocks a bunch of text only ads towards the bottom of the page.

I think I'd rather use 

a:link[href*="adimp.excite.co.jp"] img
table.ad_table

than blocking the text links the other way.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: May omnibus ad-blocking

This fixes these sites plus all the dependent bugs.  I generalized the existing netavenir rule because we discovered in bug 435800 that they serve from .com and .fr.

Comment 5

[philippe (part-time)]

Oopsie, I realise now that I forgot to link to bug 436766, which has (had ?, because I don't see it, right now).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> Oopsie, I realise now that I forgot to link to bug 436766, which has (had ?,
> because I don't see it, right now).

Let's get that next month; I want to discuss those first ;)

Landed on the trunk.  Nominating for 1.6.2, but it may not have enough baking time before we spin.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This has baked on the trunk for two weeks now with no complaints, so I'm going to land it for 1.6.2 (in part so ad-blocking doesn't get so far behind on the branch).

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on 1_8 in advance of 1.6.2.