435800 - Ads on viedemerde.fr

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Pierre Rudloff]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; fr; rv:1.8.1.14) Gecko/20080512 Camino/1.6.1 (MultiLang) (like Firefox/2.0.0.14)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; fr; rv:1.8.1.14) Gecko/20080512 Camino/1.6.1 (MultiLang) (like Firefox/2.0.0.14)

There are some ads on http://www.viedemerde.fr/ (on the right hand side).

Reproducible: Always

Steps to Reproduce:
1.Go to http://www.viedemerde.fr/
2.See ads on the right
Actual Results:  
Ads

Expected Results:  
No ads

Here is the code :


	<div class="box publicite">
		<script type="text/javascript" src="http://engine.espace.netavenir.com/?zid=1990"></script><noscript><a href="http://www.netavenir.fr/">Net Avenir : gestion publicitaire<img src="http://engine.espace.netavenir.com/?zid=1990&amp;noscript=true" width="0" height="0" border="0" alt="Net Avenir : gestion publicitaire" /></a></noscript>

	</div>

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

philippe, how safe do you think "publicite" is?  Would it unambiguously be used for advertisements, or could it also be used as a class on things we would not want to block?

Even if we can't block the whole <div> by using that class, we should safely be able to zap the ads with

a:link[href*="netavenir.com"] img,
a:link[href*="netavenir.fr"] img,
img[src*="netavenir.com"],
img[src*="netavenir.fr"]

Comment 2

[philippe (part-time)]

div[class*="publicite"] should be fairly safe.

Pierre, could you test this out ?
Right click on Camino-app > Show Package Contents and navigate to: Contents > Resources; open ad_blocking.css in a plain text editor and add at the bottom:

div[class*="publicite"] {display:none !important;}

You'll need to restart Camino. If you see real content missing on other sites, let us know.


---
Note for the other selectors: while casually browsing that site, I also had some Flash based ad. Src contained netavenir. if Flashblock didn't lie to me.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We're currently only blocking iframes from certain netavenir subdomains, so adding Flash if you've seen it would be good; I didn't notice any, which is why I didn't add list that in comment 1.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I realized we could block .com and .fr in a single rule, so

a:link[href*="netavenir."] img, 
img[src*="netavenir."], 
embed[type="application/x-shockwave-flash"][src*="netavenir."],
div[class*="publicite"],

and fixed the existing iframe rule to be

iframe[src*=".netavenir."],

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FIXED on trunk by checkin of bug 433349.