433352 - Day/week view: category color is used for the entire event box

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051122 Calendar/0.6a1

Steps to Reproduce:
1. Go to Tools -> Options -> Categories and set up a category with color
2. Create an non-all-day event with that category assigned
3. Check the event in day or week view

Actual Results:
The category color is used for the entire event box.

Expected Results:
Event box is displayed in calendar color. Category color is only used for the right border.

Comment 1

[Martin Schröder [:mschroeder]]

Also confirmed for Mozilla1.8 branch. But it seems to happen only for newly created categories.

Comment 2

[Stefan Sitter [:ssitter]]

(In reply to comment #1)
Happens also for existing events and categories as soon as a color is set for a category.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix v2

This takes care of

* fixing the category color
* bug 416604 and probably also bug 432957
* Consolidating doubleclick handler for agenda listbox

While looking at this issue, some other problems have emerged regarding the agenda pane.

Comment 4

[Berend Cornelius]

Patch works good and looks fine. You've fixed some bugs and improved the sourcecode at some other parts where it was obviously wrong on the way. Well done!
- category rules are no longer applied to calendar-boxes. So this bug seems to be fixed for me.
- Bug 416604 -> seems to be fixed by your patch. I just noticed that you have a leftover in the "agenda-richlist-item" binding:
><field name="mItem">null</field>;
The declaration of "mItem" is already done in the parent binding 
- bug 432957 could not be reproduced anymore. As the anonymous calendar-month-day-box-item-box inside the allday-richlistitem is not used inside a calendarview it also does not have a "calendarView"-object. So your fix is good enough.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 6

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008051510 Calendar/0.9pre.

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051511 Calendar/0.6a1.