Closed Bug 433352 Opened 15 years ago Closed 15 years ago

Day/week view: category color is used for the entire event box

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: Fallen)

References

Details

(Keywords: regression)

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051122 Calendar/0.6a1

Steps to Reproduce:
1. Go to Tools -> Options -> Categories and set up a category with color
2. Create an non-all-day event with that category assigned
3. Check the event in day or week view

Actual Results:
The category color is used for the entire event box.

Expected Results:
Event box is displayed in calendar color. Category color is only used for the right border.
Also confirmed for Mozilla1.8 branch. But it seems to happen only for newly created categories.
(In reply to comment #1)
Happens also for existing events and categories as soon as a color is set for a category.
Attached patch Fix v2Splinter Review
This takes care of

* fixing the category color
* bug 416604 and probably also bug 432957
* Consolidating doubleclick handler for agenda listbox

While looking at this issue, some other problems have emerged regarding the agenda pane.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #320882 - Flags: review?(Berend.Cornelius)
OS: Windows XP → All
Hardware: PC → All
Patch works good and looks fine. You've fixed some bugs and improved the sourcecode at some other parts where it was obviously wrong on the way. Well done!
- category rules are no longer applied to calendar-boxes. So this bug seems to be fixed for me.
- Bug 416604 -> seems to be fixed by your patch. I just noticed that you have a leftover in the "agenda-richlist-item" binding:
><field name="mItem">null</field>;
The declaration of "mItem" is already done in the parent binding 
- bug 432957 could not be reproduced anymore. As the anonymous calendar-month-day-box-item-box inside the allday-richlistitem is not used inside a calendarview it also does not have a "calendarView"-object. So your fix is good enough.
Attachment #320882 - Flags: review?(Berend.Cornelius) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.9
Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/2008051510 Calendar/0.9pre.

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051511 Calendar/0.6a1.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.