433361 - API for search should have a param to specify inclusion of sandboxed addons.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, enhancement, P1)

Description

[Laura Thomson :laura]

This is a follow on from bug 415263.  

In order to make the Addons Manager work as expected, the API is now returning only public add-ons.  We need to add a parameter that allows the client to specify all (including sandboxed) addons.

Comment 1

[Laura Thomson :laura]

I should point out that we also discussed changing the XML significantly, so we return one stanza per version, with a matching install element per version of the addon, and application version information per addon version.

Comment 2

[Wil Clouser [:clouserw]]

As I mentioned in bug 415263, I'd rather this default to show all and have a param to filter the results to show only public add-ons.

Comment 3

[Laura Thomson :laura]

Yes, you are correct, sorry about that.

Comment 4

[Justin Scott [:fligtar]]

Kicking out of 3.5 - not related to Dev CP revamp.

Comment 5

[Kohei Yoshino]

As an API user, I really would like to see this happen.

Comment 6

[Kohei Yoshino]

Attachment: patch v1

I have not tested it yet, but it adds the exp=on switch like normal add-ons browsing.

Comment 7

[Wil Clouser [:clouserw]]

Laura, can you take a look at this when you get a chance?

Comment 10

[Kohei Yoshino]

Can anyone test/modify/review my patch? AMJ (https://wiki.mozilla.org/Japan/AMJ) team would like to implement this feature in Q1 2010. Thanks in advance.

Comment 11

[Wil Clouser [:clouserw]]

SAMO is getting reworked in 5.7 (february).  Let's try to get this in then.

Comment 12

[Laura Thomson :laura]

Is it still worth looking at the patch or should it wait for the new SAMO?

Comment 13

[Wil Clouser [:clouserw]]

Comment on attachment 402067 [details] [diff] [review]
patch v1

(In reply to comment #12)
> Is it still worth looking at the patch or should it wait for the new SAMO?

don't worry about it

Comment 14

[Wil Clouser [:clouserw]]

Kicking this up to P1 with bug 543559

Comment 15

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

So I believe the discussion is, for API version < 1.5 , sandboxed addons won't be shown without a parameter (e.g. ?show_sandbox=1)

After v1.5 showing sandbox'd addons will be the default and can be hidden with (?hide_sandbox=1)

Comment 16

[Wil Clouser [:clouserw]]

for API versions < 1.5 there is no way to show sandbox add-ons.  After 1.5, showing them is the default and they can be hidden with a flag.

Comment 17

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

great, even easier.

Comment 18

[Kohei Yoshino]

(In reply to comment #16)
> for API versions < 1.5 there is no way to show sandbox add-ons.  After 1.5,
> showing them is the default and they can be hidden with a flag.

I can see sandboxed add-ons for v1.2:
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6

And the hide_sandbox param doesn't work:
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6?hide_sandbox=1
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6?hide_sandbox=1

I think this works as expected:
https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6

Comment 19

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Still?  I verified that these are working as expected.

(In reply to comment #18)
> (In reply to comment #16)
> > for API versions < 1.5 there is no way to show sandbox add-ons.  After 1.5,
> > showing them is the default and they can be hidden with a flag.
> 
> I can see sandboxed add-ons for v1.2:
> https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6
> 
> And the hide_sandbox param doesn't work:
> https://preview.addons.mozilla.org/z/en-US/firefox/api/1.2/search/firebug/all/100/macosx/3.6?hide_sandbox=1
> https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6?hide_sandbox=1
> 
> I think this works as expected:
> https://preview.addons.mozilla.org/z/en-US/firefox/api/1.5/search/firebug/all/100/macosx/3.6

Comment 20

[Kohei Yoshino]

Hmm, now it seem to work as expected. Great!!