Ubuntu 8.04's firefox install breaks 3.0pre's addons

VERIFIED FIXED in mozilla1.9

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: vlad, Assigned: mossop)

Tracking

Trunk
mozilla1.9
x86
Linux
Points:
---
Bug Flags:
blocking1.9 -
wanted1.9 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [RC2+])

Attachments

(1 attachment)

Ubuntu firefox-3.0~b5+nobinonly-0ubuntu3
Nightly 20080151204

Create a profile using the ubuntu firefox:

/usr/bin/firefox -createProfile mold -no-remote
/usr/bin/firefox -P mold -no-remote
.. quit ..

Open nightly firefox with the created profile:

~/firefox/firefox -P mold -no-remote

12:03 < vlad> Mossop: so I created a profile with ubuntu's
12:03 < vlad> I open that profile in latest trunk
12:04 < vlad> in addons mgr, I see "Ubuntu Firefox Modifications 0.5"  "This 
              add-on will be uninstalled when Minefield is restarted."
12:04 < vlad> (I didn't do anything to get it there)
12:04 < vlad> clicking restart restarts, and gets me back to the same state
12:04 < vlad> if I try to install any addon, I get an error
12:05 < vlad> Minefield could not install the file at ... because: Unexpected 
              installation error
12:05 < vlad> Error: installLocation is null
12:05 < vlad> Source File: 
              file:///home/vladimir/firefox/components/nsExtensionManager.js
12:05 < vlad> Line: 7971
12:05 < vlad> the (new) extension is half-installed in the profile dir
12:06 < vlad> is there an existing bug I should be referencing?
12:06 < vlad> oh, in error console, first entry is 'oldLocation is null' Line 
              7867
12:06 < vlad> then a bunch of No chrome package registered for chrome://ubufox

I can "fix" this profile by editing prefs.js and deleting the extensions.enabledItems pref.
(Assignee)

Comment 1

9 years ago
I think we should consider whether to block on this. When switching from a custom build to the official build the effect is that new add-ons cannot be installed and all existing add-ons do not work. However it does appear restricted to Ubuntu, SuSE and Fedora users should not be affected. I have not looked into other distributions. Additionally users can work around the issue by deleting the extensions.rdf file from their profile folder. So perhaps the impact is small enough that we could defer to a point release.

This is really a missed case from bug 356370. In Ubuntu's customised Firefox the default theme is in a special install location (gre-global). When the official Firefox runs it knows nothing of this install location so it must clear out the bad data from the datasource. However before the code that does this kicks in a different copy of the default theme is detected in the Firefox application directory. The process of installing this hits two points where it tries to access the unknown install location and throws an error meaning the bad entries are never cleaned up properly.

I do have a simple and low risk patch practically ready that fixes the issue and includes additional cases for the unit test for bug 356370 to properly test this scenario.
Assignee: nobody → dtownsend
Flags: blocking-firefox3?
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
Dave, any idea if we can get Ubuntu to fix this through an update on their side when they move to Firefox 3 final?

I don't think this blocks final, but yes, good for point release. Get the patch up and reviewed ASAP, and mark it approval1.9? when it's ready to go. If we do an RC2 we'll take it, if not, we'll get it in 3.0.1 :)
Flags: wanted1.9.0.x+
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Whiteboard: [RC2?]
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> Dave, any idea if we can get Ubuntu to fix this through an update on their side
> when they move to Firefox 3 final?

It is not something Ubuntu could fix (short of completely changing their packaging structure for XULRunner based applications). However when they update to Firefox 3 final they will still be using the same customisations so it will not affect users. It only affects people switching from the Ubuntu customised Firefox to the Official Mozilla Firefox
(Assignee)

Comment 4

9 years ago
Created attachment 320749 [details] [diff] [review]
patch rev 1

So there two failures that we experience when having a theme registered in an unknown install location and a new copy of that theme detected in a new install location.

First is specific to themes, when building the new active list we call getItemForID which attempts to build data from the in-datasource (invalid) instance of the theme, which tries to query the theme's icon and preview image which fails. That is a simple fix.

Secondly when updating the visible list the old instance of the add-on causes an |oldLocation is null| failure. We can just always update the visible list if the oldLocation is unknown.

The unit test is just more easily done by adding this case to the unit test for bug 356370. It adds a theme in an unknown location and then copies in the install.rdf for a matching theme to the profile and allows it to be detected on startup. This fails on both the above issues without the patch and passes with.
Attachment #320749 - Flags: review?(robert.bugzilla)
Comment on attachment 320749 [details] [diff] [review]
patch rev 1

nice!
Attachment #320749 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Comment 6

9 years ago
Comment on attachment 320749 [details] [diff] [review]
patch rev 1

Seeking approval to land. The actual code changes are minor and would have no impact on normal operation, only correcting error cases. It has unit test coverage.
Attachment #320749 - Flags: approval1.9?
(Assignee)

Updated

9 years ago
Duplicate of this bug: 433844
(Assignee)

Comment 8

9 years ago
We ought to note this in the release notes for RC1 I think
Keywords: relnote
(Assignee)

Updated

9 years ago
Duplicate of this bug: 430803
(Assignee)

Updated

9 years ago
Duplicate of this bug: 434051

Updated

9 years ago
Whiteboard: [RC2?] → [RC2?][RC2+]

Comment 11

9 years ago
Comment on attachment 320749 [details] [diff] [review]
patch rev 1

a+ please land on CVS trunk.
Attachment #320749 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 12

9 years ago
Landed on CVS trunk. Leaving open till I can figure out what to do about hg

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--  nsExtensionManager.js.in
new revision: 1.288; previous revision: 1.287
done
Checking in toolkit/mozapps/extensions/test/unit/test_bug356370.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug356370.js,v  <--  test_bug356370.js
new revision: 1.2; previous revision: 1.1
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug356370.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug356370.rdf,v  <--  test_bug356370.rdf
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug356370_4.rdf,v
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug356370_4.rdf;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug356370_4.rdf,v  <--  test_bug356370_4.rdf
initial revision: 1.1
done
Target Milestone: --- → Firefox 3
Dave, shouldn't it get Target Milestone: Firefox 3.1? It's only checked in on trunk right now. Will we have a new keyword for fixed bugs on 3.0 branch?
If we spin RC2, this will be in Firefox 3.0.
Whiteboard: [RC2?][RC2+] → [RC2+]
We'll be merging back to HG (bug 433426) so we don't need to explicitly track these landings at this time.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
clint, tomcat, do either of you have ubuntu 8.0.4?  if so, can you verify this bug on rc2?  Thanks.

Comment 17

9 years ago
(In reply to comment #16)
> clint, tomcat, do either of you have ubuntu 8.0.4?  if so, can you verify this
> bug on rc2?  Thanks.
> 
I take this :-D

Comment 18

9 years ago
verified on RC2 build 2: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008052912 Firefox/3.0

with Ubuntu 8.04.

Status: RESOLVED → VERIFIED
Keywords: relnote
Depends on: 437344
(Assignee)

Updated

9 years ago
No longer depends on: 437344
Product: Firefox → Toolkit
Flags: wanted1.9.0.x+
You need to log in before you can comment on or make changes to this bug.