433431 - Searching for substring "flag" of "flagfox" doesn't find results

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

When I set extensions.getAddons.search.url to https://remora-trunk.php5stage.mozilla.com/%LOCALE%/%APP%/api/%API_VERSION%/search/%TERMS%/all/10/%OS%/%VERSION%, and search for "flag" using Firefox 3 beta 5, I get "no matching add-ons".

However, when I search for "fla" or "flagfox", I see the search result(s) I expect, respectively.

Seems to work fine in production, that is, when extensions.getAddons.search.url is https://services.addons.mozilla.org/%LOCALE%/%APP%/api/%API_VERSION%/search/%TERMS%/all/10/%OS%/%VERSION%

Comment 1

[Michael Morgan [:morgamic]]

https://remora-trunk.php5stage.mozilla.com/en-US/firefox/api/1.1/search/flag/all/10/Darwin/3.0pre

vs.

https://services.addons.mozilla.org/en-US/firefox/api/1.1/search/flag/all/10/Darwin/3.0pre

Why?

Comment 2

[Michael Morgan [:morgamic]]

And then, the real kicker is:
https://remora-trunk.php5stage.mozilla.com/en-US/firefox/api/1.1/search/fla/all/10/Darwin/3.0pre

That is what really confuses me...

Comment 3

[Laura Thomson :laura]

The same set of searches through the regular UI work as expected, which isolates the bug somewhat.

Comment 4

[Dave Garrett]

Uh... bizarre.

First thing I get with URL #1 is it yelling at me for an unknown certificate issuer, in an alert() no less.  No part of that is nice.  ;)

After adding the exception I easily reproduced it.  Even easier to reproduce by lazily clicking on the links in comment #1 and comment #2.  Something is quite fubared somewhere.

Comment 5

[Dave Garrett]

Is "flag" somehow a reserved word somewhere?

Comment 6

[Laura Thomson :laura]

The regression is caused by the fix for bug 415263.  Revisiting and reopening that.

Comment 7

[Laura Thomson :laura]

Attachment: Fix 433431 by doing fix for 415263 a better way that even clouserw should like.

Comment 8

[Chris Pollett]

Comment on attachment 320643 [details] [diff] [review]
Fix 433431 by doing fix for 415263 a better way that even clouserw should like.

patch fixes flagfox problem and also addresses other bug menioned above by Laura

Comment 9

[Laura Thomson :laura]

Fixed in r13083.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with my testcase in comment 0; is the discrepancy between 8 results and 12 results in the 1st and 2nd URLs in comment 1 due to us not displaying sandboxed add-ons?  (Anyway, that's not this bug, and probably not a bug...)