43347 - nsComponentManager doesn't check retval of PlatformInit(), can lead to crashes

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Mark G. Adams]

xpcom/components/nsComponentManager doesn't check the return value of the
PlatformInit() call. That method must complete successfully for the native
component loader to be initialized, which otherwise leads to a crash.

Patch:
------------------------------------------------------
Index: nsComponentManager.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpcom/components/nsComponentManager.cpp,v
retrieving revision 1.128
diff -u -r1.128 nsComponentManager.cpp
--- nsComponentManager.cpp      2000/06/15 02:20:29     1.128
+++ nsComponentManager.cpp      2000/06/21 20:19:08
@@ -318,7 +318,13 @@

 #ifdef USE_REGISTRY
         NR_StartupRegistry();
-        PlatformInit();
+        {
+            nsresult ret;
+            ret = PlatformInit();
+            if( NS_FAILED( ret ) ) {
+                return ret;
+            }
+        }
 #endif

     PR_LOG(nsComponentManagerLog, PR_LOG_ALWAYS,

Comment 1

[leger]

Adding crash keyword

Comment 2

[Ray Whitmer]

This fix should be applied fairly soon.  While it does not stop mozilla from
initializing correctly, it produces a messy crash instead of a nicer exit if
something is wrong so that it cannot execute correctly.

Comment 3

[Ray Whitmer]

Adding nsbeta3 and patch keywords.

Comment 4

[Ray Whitmer]

Applied the patch, exactly as given.

Comment 5

[Tracy Walker [:tracy]]

please verify

Comment 6

[leger]

Mark, can you mark Verified now?