433555 - Don't show quick review radio group when not logged in with JavaScript disabled

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[Dave Garrett]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008051204 Minefield/3.0pre
Build Identifier: 

With JavaScript enabled, the quick review box (upper right of public pages) uses 5 selectable stars.  With JavaScript disabled it resorts to a radio group with hate/like/love it options.  This is ugly, but necessary without JavaScript in use.  To make this less-so for more people, I suggest just showing the greyed-out stars that you get with JavaScript on when off and logged out.  (can't write a review when logged out)  Only show the actual selections when forced to; only when logged in.

Reproducible: Always

Comment 1

[Fred Wenzel [:wenzel]]

Unfortunately, the whole star rating magic is added by JavaScript, so in order to make this work we'd probably get a bunch of additional complexity here that wouldn't help most users. (I am saying this because NoScript users usually have mozilla on their whitelist, and by far the most users have JS enabled by default).

Comment 2

[Dave Garrett]

(In reply to comment #1)
> Unfortunately, the whole star rating magic is added by JavaScript, so in order
> to make this work we'd probably get a bunch of additional complexity here that
> wouldn't help most users.

I'm not suggesting anything so complex.  All that would be needed would be a static image of the 5 greyed-out stars.  Nothing more.  It's not like this does anything when not logged in, so I don't think we should bother showing the radio group unless you are.

You should be able to do this easily in PHP on the server side.  Just check for being logged in around the radio group and show that if logged in or the stars image if not.

I do agree, however, that this is not top priority.

Comment 3

[Wil Clouser [:clouserw]]

It's a dropdown now.  Still not beautiful, but I'm calling this fixed.  If you disagree, we can call it wontfixed. :)

Comment 4

[Dave Garrett]

Oh, beauty is in the eye of the bugtester. It's more than satisfactory. :)