433567 - Replace Mozilla Corporation references with Mozilla Messaging

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect, P1)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

While testing Shredder Alpha 1, I also noticed that Mozilla Messaging should now replace Mozilla Corporation.

E.g. Right-clicking thunderbird.exe in Vista shows the Digital Signature as "Mozilla Corporation", while the UAC dialog lists the setup program as Thunderbird and "Mozilla Corporation".

There might be other references elsewhere as well.

Comment 1

[Magnus Melin [:mkmelin]]

This sounds like it needs fixing for 3; blocking‑thunderbird3+

Moving to installer as that's where the mentioned instances should be fixed.

Comment 2

[Mark Banner (:standard8)]

I'm sure we'll pick these up easily anyway, but here are some file references:

http://mxr.mozilla.org/seamonkey/source/other-licenses/branding/thunderbird/license.r
http://mxr.mozilla.org/seamonkey/source/mail/app/module.ver
http://mxr.mozilla.org/seamonkey/source/mail/EULA.rtf
http://mxr.mozilla.org/seamonkey/source/mail/LICENSE.txt

I guess changing the licenses shouldn't be a problem, we might just need to check with Gerv that they are ok.

Comment 3

[Mark Banner (:standard8)]

Attachment: [checked in] Change name on executable in windows.

This is the simple change - change the name of the company on the windows executable. I think the other changes we need should probably have a licensing review by gerv, and I've a feeling the digital signing issues are probably a build/release issue.

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #2)
> I'm sure we'll pick these up easily anyway, but here are some file references:
> 
> http://mxr.mozilla.org/seamonkey/source/other-licenses/branding/thunderbird/license.r
> http://mxr.mozilla.org/seamonkey/source/mail/EULA.rtf
> http://mxr.mozilla.org/seamonkey/source/mail/LICENSE.txt

Garry, fancy picking up this bug and doing the change in these remaining files?

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #4)
> (In reply to comment #2)
> > I'm sure we'll pick these up easily anyway, but here are some file references:
> > 
> > http://mxr.mozilla.org/seamonkey/source/other-licenses/branding/thunderbird/license.r
> > http://mxr.mozilla.org/seamonkey/source/mail/EULA.rtf
> > http://mxr.mozilla.org/seamonkey/source/mail/LICENSE.txt
> 
> Garry, fancy picking up this bug and doing the change in these remaining files?

Sure, but I've a question -- is a direct replacement of "Mozilla Corporation" with "Mozilla Messaging" in the legal lingo (i.e. EULA, licensing) sufficient?

Or should it be replaced with "Mozilla Messaging, Inc."?

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch for remaining files

I did a blanket replacement to "Mozilla Messaging, Inc." as the correct legal name, David mentions this is alright.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 344223 [details] [diff] [review]
patch for remaining files

These look fine, and as long as David is happy, so am I.

Comment 8

[Reed Loden [:reed]]

"The Mozilla Messaging, Inc." makes little sense... "Incorporated" is not a thing... should just drop the "The" and just have "Mozilla Messaging, Inc."

You don't see Google's agreements saying "The Google, Inc." :)

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #8)
> "The Mozilla Messaging, Inc." makes little sense... "Incorporated" is not a
> thing... should just drop the "The" and just have "Mozilla Messaging, Inc."
> 
> You don't see Google's agreements saying "The Google, Inc." :)

They were just a blanket replacement for the original "The Mozilla Corporation", perhaps someone with legal lingo authority can comment..

Comment 10

[David Ascher (:davida)]

Reed is right.

Comment 11

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2

patch v2 removing the "The" word, requesting review from David to ensure this tastes good. :)

Comment 12

[David Ascher (:davida)]

Comment on attachment 344282 [details] [diff] [review]
patch v2

It looks good to me, but if Catherine doesn't mind looking at a diff, I'd feel better about it.

Comment 13

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Catherine, please set review+ and comment if the patch is ok. Thanks!

Comment 14

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/94c92735e24c

Signing builds are being dealt with in other discussions.